Refactored code (Part 3)#367
Refactored code (Part 3)#367NullVoxPopuli merged 11 commits intoember-tooling:mainfrom ijlee2:refactor-code-part-3
Conversation
|
@NullVoxPopuli Can you help with reviewing this PR and #368? |
What's the benefit of doing this though? Much of the content that code can just be deleted (in a separate pr), and would shrink this pr (yay!) I do like smaller files tho! |
Currently, the files don't practice a good separation of concerns. As a result, I think the package will feel more magical to contributors than it actually is. This, in return, would make maintaining and extending the package difficult. |
|
I'm a fan of the new structure presented here |
| @@ -0,0 +1,3 @@ | |||
| export * from './ambiguity.js'; | |||
There was a problem hiding this comment.
let's avoid export * as it hides the true api surface area size
|
Sorry @ijlee2, you'll have to rebase again 🙈 |
|
Rebased. |
NullVoxPopuli
left a comment
There was a problem hiding this comment.
tyty for reminding me about this <3
Background
I moved the existing code around so that we can simplify
src/main.tsand the file structure better matches that inprettier-plugin-ember-hbs-tag.