Skip to content

Updated dependencies#362

Merged
NullVoxPopuli merged 6 commits intoember-tooling:mainfrom
ijlee2:update-dependencies
Jun 13, 2025
Merged

Updated dependencies#362
NullVoxPopuli merged 6 commits intoember-tooling:mainfrom
ijlee2:update-dependencies

Conversation

@ijlee2
Copy link
Copy Markdown
Contributor

@ijlee2 ijlee2 commented Jun 6, 2025

Background

A few dependencies have had a major release:

  • content-tag
  • eslint
  • pnpm
  • prettier (likely some breaking changes in a minor version)
  • typescript-eslint
  • vitest

By updating these to the latest version, we can continue to maintain this project.

@ijlee2 ijlee2 marked this pull request as ready for review June 6, 2025 05:00
Comment thread package.json Outdated
Comment thread package.json
Comment thread src/utils/content-tag.ts Outdated
Comment thread examples/bin/test.mjs
Comment thread examples/bin/test.mjs
Comment thread package.json
Comment thread src/parse/index.ts Outdated
Comment thread src/parse/preprocess.ts
Comment thread src/parse/preprocess.ts Outdated
Comment thread src/utils/content-tag.ts Outdated
Comment thread tests/unit-tests/preprocess.test.ts Outdated
@ijlee2 ijlee2 mentioned this pull request Jun 6, 2025
@ijlee2 ijlee2 requested a review from NullVoxPopuli June 6, 2025 16:29
Comment thread src/parse/preprocess.ts
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you rebase? I'm surprised this diff is still here 🤔

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I did rebase after #363 had been merged.

I'm not sure what about the diff surprised you. It looks okay to me (i.e. the changes to this file are what I had intended). Can you clarify for me?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I guess I'm surprisde there is still non-dependency updates in the dependency update PR.

since the refactor is related to content-tag, it should be in a separate PR, and maybe content-tag updating also be in a separate PR.

This PR is in conflict tho -- I pulled some of your changes out to another PR, #365
thanks for doing this! It's good to get things updated.

With #365 merged, this #362 will be a bit smaller, and we can keep iterating 🎉

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. See #366.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! now this one has conflicts 🙈

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem.

Comment thread package.json
"eslint-plugin-n": "^17.12.0",
"eslint": "^9.28.0",
"eslint-config-prettier": "^10.1.5",
"eslint-plugin-jsdoc": "^50.8.0",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NullVoxPopuli NullVoxPopuli added the internal Internal changes that still require a mention in the changelog/release notes label Jun 13, 2025
@NullVoxPopuli NullVoxPopuli merged commit a7f3d34 into ember-tooling:main Jun 13, 2025
4 checks passed
@github-actions github-actions Bot mentioned this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal changes that still require a mention in the changelog/release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants