refactor(i18n): improve korean translations - #1137
Open
bunubbv wants to merge 12 commits into
Open
Conversation
bunubbv
changed the title
bunubbv
marked this pull request as ready for review
July 23, 2026 14:06
Author
|
Author
|
The greeting currently appends the user's name to the translated string, making natural Korean phrasing such as "안녕하세요, (name)님." impossible. Separate strings are needed for greetings with and without a name. |
Author
|
@1-vL I'd appreciate your review on this, whenever you have some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.