Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lighter/ws_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ def on_message(self, ws, message):
if isinstance(message, str):
message = json.loads(message)

if not isinstance(message, dict):
return

message_type = message.get("type")

if message_type == "connected":
Expand All @@ -61,7 +64,12 @@ def on_message(self, ws, message):
self.handle_unhandled_message(message)

async def on_message_async(self, ws, message):
message = json.loads(message)
if isinstance(message, str):
message = json.loads(message)

if not isinstance(message, dict):
return

message_type = message.get("type")

if message_type == "connected":
Expand Down
21 changes: 21 additions & 0 deletions test/test_ws_client.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import unittest

from lighter.ws_client import WsClient


class TestWsClient(unittest.IsolatedAsyncioTestCase):
def setUp(self):
self.client = WsClient(order_book_ids=[0])

def test_sync_ignores_json_string_message(self):
self.client.on_message(None, '"heartbeat"')

async def test_async_ignores_json_string_message(self):
await self.client.on_message_async(None, '"heartbeat"')

async def test_async_ignores_decoded_non_object_message(self):
await self.client.on_message_async(None, ["heartbeat"])


if __name__ == "__main__":
unittest.main()