feat: add setSettings overload accepting an update function - #169
Open
GeekyEggo wants to merge 5 commits into
Open
feat: add setSettings overload accepting an update function#169GeekyEggo wants to merge 5 commits into
GeekyEggo wants to merge 5 commits into
Conversation
🦋 Changeset detectedLatest commit: 28e65c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds functional settings updates to ActionBase.
Changes:
- Supports synchronous and asynchronous updater functions.
- Adds updater and cache-invalidation tests.
- Expands controller type assertions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
action-base.ts |
Adds the setSettings updater overload. |
action.test.ts |
Tests updater behavior and type assertions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+132
to
+133
| const payload = | ||
| typeof settingsOrUpdate === "function" ? await settingsOrUpdate(await this.getSettings()) : settingsOrUpdate; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new overload to
setSettingsthat accepts an update function, allowing settings to be modified based on the current value.Changes
setSettings(update: (current: TSettings) => Promise<TSettings> | TSettings)overload toActionBase