Repository navigation
SettingsSidebarRow: use Granite.HeaderLabel - #409
danirabbit wants to merge 4 commits into
Conversation
danirabbit
commented
Nov 3, 2026
danirabbit
commented
- Use HeaderLabel instead of multiple labels
- Use Granite.Box instead of setting margins manually
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
LGTM, only one comment :)
| public Icon icon { get; set; } | ||
|
|
||
| public string status { | ||
| set { | ||
| status_label.label = value; | ||
| status_label.visible = true; | ||
| update_property (Gtk.AccessibleProperty.DESCRIPTION, value, -1); | ||
| } | ||
| } | ||
|
|
||
| public string title { | ||
| get { | ||
| return _title; | ||
| } | ||
| set { | ||
| _title = value; | ||
| title_label.label = value; | ||
| update_property (Gtk.AccessibleProperty.LABEL, value, -1); | ||
| } | ||
| } | ||
| public string? header { get; set; } | ||
| public string? status { get; set; } | ||
| public string title { get; set; } |
There was a problem hiding this comment.
I think we should drop those properties. Ig in the past they were used as an easy way to bind properties from the page that set the appropriate things but with this PR that's not necessary anymore. The only thing that's used from the outside afaict is header and I think the user should instead go through our page property.
There was a problem hiding this comment.
I actually wonder if we shouldn't go the other way around. Eventually I want to use ListView instead of ListBox since we have some sidebars with lots of searchable items and rows should be settable. At the moment we have some custom sidebar implementations and it would be nice to make this widget public and re-use it, without having to use SettingsPage since there's a lot of assumptions about it being used with a Stack and with few items etc that shouldn't apply in the future
There was a problem hiding this comment.
I've removed them for now since they're unused, though and we can revisit that later I suppose
