[danirabbit]

• Replace listbox.filter_func with a filter model
• Take the query as a string instead of holding a reference to a UI element
• When query changes, compare to the old query to see if we can filter the previous results and go faster
• Use GLib's match_string so we can also get results regardless of accent usage

[leolost2605]

Did you look at Gtk.StringFilter?

[danirabbit]

@leolost2605 I opened a branch here using StringFilter instead. The only thing is I'm not sure how we can also update pattern so the search result label gets marked up

[leolost2605]

Yeah I don't have a good idea for that either. We could just bind the query property to the pattern of every row. Right now that's a bit problematic because we actually have to do it for every row but eventually we could bind in list_view.bind and unbind in list_view.unbind which should scale much better and make the performance good AFAICT (though with the limited amout of search options performance shouldn't be bad right now either).

I wouldn't mind the current way it's done but unfortunately CustomFilter is always a bit tricky and in this case it would leak memory (see review comment)

[leolost2605]

If the filter func is not static we will get a reference cycle :(

us -> filter model -> filter -> callback target (= us)