docs: clarify when to call flipFuses()#124
Merged
Merged
Conversation
Clarify that flipFuses() should run after the app is packaged (all files in place) but before code signing, and note that it fits naturally in an electron-builder afterPack hook or an electron-forge hook. Closes #61
MarshallOfSound
approved these changes
Jun 28, 2026
MarshallOfSound
marked this pull request as ready for review
June 28, 2026 17:20
erikian
approved these changes
Jun 28, 2026
|
🎉 This PR is included in version 2.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard · Slack thread
The "Via JavaScript" example uses the comment
// During your build / package process, which is ambiguous about when in the build the call should happen. This clarifies the timing.Before: A reader sees the example annotated only with
// During your build / package processand has no guidance on whether to flip fuses before or after packaging, or how it relates to code signing.After: The comment explains that
flipFuses()should run after the app has been packaged (all files in place) but before code signing, and points to the natural integration points: an electron-builderafterPackhook or an electron-forge hook.Closes #61
Generated by Claude Code