Repository navigation
ci: add required-ci gate job - #472
Merged
Merged
Conversation
Add a single `required-ci` job to the Test workflow that depends on the test matrix and fails if any needed job failed or was cancelled, so branch protection can require one stable check name. Mirrors electron/forge. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rx13DJRnFBvVNh1ioMMXsQ
MarshallOfSound
approved these changes
Sep 27, 2026
Contributor
Author
There was a problem hiding this comment.
LGTM — straightforward CI config change.
What was reviewed:
- The new
required-cijob's dependency ontestand itsif: always()gating logic - Correctness of
contains(needs.*.result, 'failure'/'cancelled')against the matrixtestjob's aggregate result - Permissions/secrets exposure — none added; job requests no elevated permissions
Extended reasoning...
The change adds one new job to .github/workflows/test.yml that gates on the existing matrix test job and fails if any leg failed or was cancelled, otherwise prints a success message — a standard "stable required check" pattern for branch protection. It touches no secrets, no elevated permissions (workflow has permissions: {} and the new job requests none), and no other code paths. The logic (needs.*.result against a matrix job) is correct and the change is small, self-contained, and mechanical, so approving without requiring further human review.
erickzhao
approved these changes
Sep 28, 2026
dsanders11
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard · Slack thread
This adds a single
required-cijob to the Test workflow that depends on thetestmatrix and fails if any of it failed or was cancelled, so branch protection can require one stable check name instead of each matrix leg. It mirrors therequired-cijob in electron/forge's CI workflow, passing job results through step-levelenv:so zizmor stays clean. Branch protection / rulesets still need to be updated separately to require the newrequired-cicheck.🤖 Generated with Claude Code
https://claude.ai/code/session_01Rx13DJRnFBvVNh1ioMMXsQ
Generated by Claude Code