Skip to content

ci: add required-ci gate job - #472

Merged
dsanders11 merged 1 commit into
mainfrom
ci/required-ci-gate
Sep 29, 2026
Merged

dsanders11 merged 1 commit into
mainfrom
ci/required-ci-gate

Conversation

@claude

@claude claude Bot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

This adds a single required-ci job to the Test workflow that depends on the test matrix and fails if any of it failed or was cancelled, so branch protection can require one stable check name instead of each matrix leg. It mirrors the required-ci job in electron/forge's CI workflow, passing job results through step-level env: so zizmor stays clean. Branch protection / rulesets still need to be updated separately to require the new required-ci check.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Rx13DJRnFBvVNh1ioMMXsQ


Generated by Claude Code

Add a single `required-ci` job to the Test workflow that depends on the
test matrix and fails if any needed job failed or was cancelled, so branch
protection can require one stable check name. Mirrors electron/forge.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Rx13DJRnFBvVNh1ioMMXsQ
@claude
claude Bot requested a review from a team as a code owner September 27, 2026 07:01

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward CI config change.

What was reviewed:

  • The new required-ci job's dependency on test and its if: always() gating logic
  • Correctness of contains(needs.*.result, 'failure'/'cancelled') against the matrix test job's aggregate result
  • Permissions/secrets exposure — none added; job requests no elevated permissions
Extended reasoning...

The change adds one new job to .github/workflows/test.yml that gates on the existing matrix test job and fails if any leg failed or was cancelled, otherwise prints a success message — a standard "stable required check" pattern for branch protection. It touches no secrets, no elevated permissions (workflow has permissions: {} and the new job requests none), and no other code paths. The logic (needs.*.result against a matrix job) is correct and the change is small, self-contained, and mechanical, so approving without requiring further human review.

@dsanders11
dsanders11 merged commit 8aa3f59 into main Sep 29, 2026
11 checks passed
@dsanders11
dsanders11 deleted the ci/required-ci-gate branch September 29, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants