Skip to content

build(deps-dev): upgrade vitest to v5 - #471

Merged
MarshallOfSound merged 1 commit into
mainfrom
vitest-5
Sep 23, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
vitest-5

Conversation

@claude

@claude claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Requested by David Sanders · Slack thread

This bumps vitest from ^4.1.5 to ^5.0.1. Vitest 5 makes vite a required peer dependency instead of a regular dependency, so vite is now a devDependency at ^8.0.16, the version already in the lockfile, and it still resolves to 8.0.16. No test or config changes were needed. On Linux, yarn lint, yarn build, yarn test:typecheck and yarn install --immutable pass, and yarn vitest run passes 203 of 203 tests in 11 files, the same as main. I could not run the second half of yarn test, which runs the suite inside Electron, because the sandbox couldn't download the Electron binary, so that part relies on CI.

🤖 Generated with Claude Code

https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF
@claude
claude Bot requested a review from a team as a code owner September 23, 2026 21:34
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedvitest@​4.1.11 ⏵ 5.0.198 +110079 +198100
Addedvite@​8.0.16991008296100

View full report

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, straightforward dev-dependency version bump. What was reviewed: package.json/yarn.lock diff for the vitest 4->5 upgrade and the new explicit vite devDependency it now requires as a peer; confirmed the lockfile changes are limited to vite/vitest and their transitive deps with no unrelated or suspicious package/registry changes; no source, build config, or runtime dependency changes are involved.

Extended reasoning...

The change is confined to package.json and yarn.lock: bumping the vitest devDependency from ^4.1.5 to ^5.0.1 and adding vite ^8.0.16 as an explicit devDependency because vitest 5 now requires vite as a peer dependency rather than pulling it in transitively. No application code, CI config, or runtime dependencies are touched, and there is no security-sensitive surface (no auth, crypto, or data handling). The lockfile diff is consistent with a mechanical yarn install after the version bump, with all changed entries traceable to vite/vitest's transitive dependency tree. No open third-party objections exist in the PR timeline, and the mechanical nature of the change supports approval without requiring human review.

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) September 23, 2026 23:13
@MarshallOfSound
MarshallOfSound merged commit 08d5657 into main Sep 23, 2026
10 checks passed
@MarshallOfSound
MarshallOfSound deleted the vitest-5 branch September 23, 2026 23:13
@electron-npm-package-publisher

Copy link
Copy Markdown

🎉 This PR is included in version 4.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants