Repository navigation
Find gh through the login shell in Kosmo's GitHub view - #170
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kosmo opened from Finder or another desktop launcher can inherit a
PATHthat cannot findgh. Run the GitHub viewer's default CLI through$SHELL -l -con POSIX, then replace the shell withghso the existing timeout, cancellation, and process cleanup still apply.Restore the project directory, clear
GH_REPO, and disable prompts and paging after login initialization. Quote each command argument so project paths containing spaces, quotes, or shell syntax remain literal. Explicit executable paths retain direct execution.Validation: compiled the shared integration runner with
nim ic; all 10 GitHub CLI integration tests pass, including actual login-profile PATH discovery, project/settings preservation, shell quoting, cancellation, timeouts, and child-process cleanup. The shared test import check andgit diff --checkalso pass.CI: all 12 build and test jobs passed, including full macOS/Linux suites, ARC/ORC ownership sanitizers, example builds, and release builds for macOS, Windows, Linux, and FreeBSD. Both the zsh and Bash login-profile regressions passed under Nim 2.2.10.