Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render Markdown task markers as ☐ (
[ ]), ☑ ([x]/[X]), and ☒ ([-]), and enable FigDraw's HarfBuzz backend so missing glyphs use system-font fallback in the editor and terminal. Prepare Merenda 0.28.0.48611dc(Harfbuzzy 0.3.0) and FigDraw PR #99 at2371c40. The rasterizer uses the same statically linked HarfBuzz implementation as shaping.nim install_kosmobuild pinned HarfBuzz and FriBidi sources through-d:harfbuzzyStatic. Remove the local installer's shared-library build and bundling steps, and copy notices from the actual pinned sources. Set native/app compiler targets explicitly for macOS 13. Other builds retain their existing dynamic-library configuration.Validation: All 12 Merenda CI checks pass at
aedb2c31: full suites, examples, and sanitizers and all release targets. All seven FigDraw checks pass at2371c40, including both Windows renderers. All four Harfbuzzy checks pass at the pinned 0.3.0 commit48611dc, including MSVC static/dynamic and MinGW dynamic builds.All 112 focused font-layout, Markdown, and monospace-editor tests pass with both text libraries static and all three dynlib overrides deliberately invalid. The same 112 tests pass dynamically against HarfBuzz 14.6.0 and FriBidi 1.0.17. Harfbuzzy's 24 local tests pass in dynamic C/C++ and static C, including invalid dynlib names and shared-library linking. The hook readiness fix passes 50 standalone process/readiness iterations and both focused end-to-end hook tests.
The updated
nim install_kosmoinstalls a signed 0.28.0 app; installedkosmo --versionand--helppass. Its static binary defines both libraries' symbols, includes both notices, and passes a loader trace loading neither text dylib. A separate signed dynamic Kosmo.app also passes version/help and opens a visible native Metal window. Its runtime logs show symbol, Hebrew, and Arabic fallback fonts loading; loader tracing confirms both bundled dylibs load, and symbol inspection confirms neither implementation is embedded.Astra reviewed the native bindings, static rasterizer, source-cache builds, MSVC runtime matching, and installer integration. It independently verified the FriBidi ABI and a sanitizer/linker-flag regression fix; no actionable findings remain.