Skip to content

@ekino/logger v3.0#48

Merged
tduyng merged 76 commits into
ekino:masterfrom
tduyng:3.0
Apr 30, 2026
Merged

@ekino/logger v3.0#48
tduyng merged 76 commits into
ekino:masterfrom
tduyng:3.0

Conversation

@tduyng
Copy link
Copy Markdown
Contributor

@tduyng tduyng commented Feb 24, 2025 •
edited
Loading

Summary

Rewrite @ekino/logger for v3.0

Motivation

  • It's been so long time the library is not matained
  • Rewrite this library for adapting the modern Node.js (Typescript, ESM)

What has changed?

Here are the key changes made in this PR:

  • Rewritten in ESM
  • Support for dual package (CommonJS and ESM)
  • Rewritten in TypeScript
  • Removed many unnecessary dependencies
  • Replaced yarn with pnpm, which is faster and more convenient with different commands and management
  • Upgraded GitHub Actions, rewrote some deprecated syntax
  • Using git-cliff on GitHub Actions for easily customizable CHANGELOG
  • Replaced ESLint + Prettier with Biome, which is faster, has sufficient rules, and is easier to set up
  • Rewrote all tests from ava + sinon.js + nyc + ts-node to vitest (compatible with ESM)
  • Create a benchmark compare with pino.js and winston
  • Refactored and cleaned up code, focusing on performance, and much more...

Test plan

  • All unit tests have been correctly rewritten with Vitest
  • All functional test behaviors are ensured

Also close issue #25 , close issue #37

tduyng added 30 commits October 21, 2024 16:00
@tduyng
chore(yarn): use yarn v2
4566757
@tduyng
chore(hooks): remove husky, use native githooks
0152daa
@tduyng
chore(deps): use exact version of dev dependencies for better local dev
999ed77
@tduyng
chore(lint): implement biome and remove eslint,prettier
e7db6b8
@tduyng
fix(lint): fix all linter issues
011198e
@tduyng
refactor(outils): remove unused function
bc3100c
@tduyng
refactor: write native colors outils
94c17cb
@tduyng
refactor(examples): give meaningfull messages
f1fd5e1
@tduyng
chore(deps): remove unused eslint and prettier
f9a94a0
@tduyng
refactor(adapters): create wrapper writable stream for process.stdout…
8b83f9f 
….write
@tduyng
feat(perf): implement fast-json-stringify for better performance json…
10d473a 
… parser
@tduyng
refactor: implement pur functional, avoid mutable internal object
245729d
@tduyng
refactor: separate default config and mutual config
eac80d7
@tduyng
fix: handle correctly dual signature for logMethod
4d6b3d1
@tduyng
feat(perf): implement memorization for caching expensive operations
8d64d9f
@tduyng
refactor: separate json schema for fast-json-stringify
afd4099
@tduyng
fix: fast-json-stringify do not support replacer
ccbb2c6
@tduyng
feat(3.0): convert src code to ESM
eb0efdc
@tduyng
feat(3.0): remove ts-node, use tsx, convert examples to typescript
dfe49fb
@tduyng
chore(3.0): ignore format package.json by biome
109b4e1
@tduyng
feat(3.0): support more colors
efb6522
@tduyng
chore(3.0): support dual npm package in ESM and CJS
70735b5
@tduyng
chore(3.0): set Node.js 18 as the minimum supported version
3a0f647
@tduyng
chore(3.0): remove unused Makefile
53d8730
@tduyng
ci(3.0): fix, update action versions, run test on Nodejs18,20,22
47c134a
@tduyng
ci(3.0): simplify release step and build Typescript files
2afacab
@tduyng
chore(3.0): run examples/*.ts with deno for faster execution
5ac9e32
@tduyng
chore(3.0): remove unused dependencies
8d79fb5
@tduyng
chore(3.0): add more tags
2a886fc
@tduyng
ci(3.0): add issue templates: bug, feature_request
9effe33
Nico385412
Nico385412 reviewed Nov 26, 2025
View reviewed changes
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread benchmarks/README.md Outdated
Comment thread benchmarks/README.md Outdated
Comment thread benchmarks/README.md Outdated
Comment thread docs/BREAKING_CHANGES.md Outdated
Comment thread examples/cjs/example3.cjs Outdated
Comment thread examples/esm/example3.js Outdated
Comment thread examples/example3.ts Outdated
@tduyng
Copy link
Copy Markdown
Contributor Author

tduyng commented Dec 3, 2025

Thank @Nico385412 for all the reviews!

atacanjacques
atacanjacques reviewed Jan 31, 2026
View reviewed changes
Comment thread package.json Outdated
Comment thread package.json Outdated
halimatou-cpu
halimatou-cpu approved these changes Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown

@halimatou-cpu halimatou-cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@tduyng tduyng force-pushed the 3.0 branch 6 times, most recently from 308b75a to d2405d7 Compare April 30, 2026 07:17
@tduyng
fix: resolve regressions and remove performance benchmarks
3112d11 
- Fix error message format for backward compatibility
- Fix setNamespaces whitespace handling
- Fix setGlobalContext to use deep copy (structuredClone)
- Export isEnabled function for namespace/level checking
- Add cache invalidation when namespaces/level change
- Remove memoize to avoid memory leak
- Remove benchmarks and performance docs (not needed)
- Update BREAKING_CHANGES.md
@tduyng tduyng merged commit fdd4f5e into ekino:master Apr 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@Nico385412 Nico385412 Nico385412 approved these changes

@atacanjacques atacanjacques atacanjacques approved these changes

@halimatou-cpu halimatou-cpu halimatou-cpu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tduyng @Nico385412 @atacanjacques @halimatou-cpu