fix(release): treat unchanged versions as ordinary merges - #21
Conversation
|
Reviewed by running it rather than only reading it, and against the exact case that broke main rather than a synthetic one. No blockers here, and the fix does what issue #10 asks for. The regression case is really fixedWith Also verified: the modified YAML parses; the provenance step and the One coverage gap, and it is mine to resolve rather than yoursOn this branch Smaller items
For the record, Nothing to change in the code from my side. Thanks for turning this around quickly, it removes the red release run on main. |
|
Also reviewed PR #21. The release-detection logic is working and Package CI is green. I found two follow-ups before merge:
The duplicate |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain, and the changes include regression coverage.
Pull request overview
Updates release detection so unchanged versions are treated as ordinary merges while valid stable increases still create annotated tags.
Changes:
- Added release-transition detection and GitHub Actions output.
- Integrated detection into the release workflow.
- Added regression tests and task documentation.
File summaries
| File | Summary |
|---|---|
tests/detect-release.test.mjs |
Tests valid, unchanged, and invalid transitions. |
scripts/detect-release.mjs |
Classifies release transitions and emits workflow output. |
odd/tasks/issue-10-release-detection.md |
Records scope, decisions, and verification. |
.github/workflows/tag-release.yml |
Uses detection before tagging while preserving safeguards. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Closes #10
Type
Summary
Changes
.github/workflows/tag-release.ymlscripts/detect-release.mjstests/detect-release.test.mjsTest Plan
npm testnode --test tests/detect-release.test.mjsgit diff --checkContributor Checklist
type:*label (type:chore).Co-Authored-Bytrailers.