Skip to content

Libvips cropping#16

Draft
tonytw1 wants to merge 79 commits into
libvipsfrom
libvips-cropping
Draft

Libvips cropping#16
tonytw1 wants to merge 79 commits into
libvipsfrom
libvips-cropping

Conversation

@tonytw1

@tonytw1 tonytw1 commented Jul 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this change?

Cropping is implemented using libvips.

Aims to only load the image once.
The image processing operations happen in memory rather than forking out to shell commands.

Nudges the Crops.cropType crop file type decision towards a more deterministic set of parameters.

isGraphic decision for crop type is inferred from the number of bands in the source image.
Do not know how to implement this colour depth query in libvibs.

 // val isGraphic = !colourType.matches("True[ ]?Color.*")

IPTC tagging

Moves to to the XMP block with the XMP block been built in memory.

Performance

Some marginal reductions on cropping time and predictable memory use.
These test images can be cropped by a container with 2Gb of memory.

Time for "POST /crops to return after making a fullset of 5:3 full frame crops of various test images.

imagemagick: 
3301x2173 image/jpeg 1324968 : 1290ms
3500x2334 image/jpeg 2492334:  2050ms
4165x3407 image/png 26741926 : 8904ms
8640x5760 image/jpeg 27134591: 5279ms
5000x3333 image/jpeg 8674990: 2521ms

vips:
3301x2173 image/jpeg 1324968 : 1127ms
3500x2334 image/jpeg 2492334 : 1307ms
4165x3407 image/png 26741926 : 5036ms
8640x5760 image/jpeg 27134591 : 4001ms
5000x3333 image/jpeg 8674990 : 1619ms

How should a reviewer test this change?

How can success be measured?

Who should look at this?

Tested? Documented?

  • locally by committer
  • locally by Guardian reviewer
  • on the Guardian's TEST environment
  • relevant documentation added or amended (if needed)

@tonytw1
tonytw1 force-pushed the libvips branch 2 times, most recently from c8f8217 to c96ff82 Compare August 11, 2025 19:06
@tonytw1
tonytw1 force-pushed the libvips branch 4 times, most recently from d296629 to 25c0148 Compare September 28, 2025 10:12
@tonytw1
tonytw1 force-pushed the libvips-cropping branch 2 times, most recently from 5997767 to 7ced3c4 Compare September 28, 2025 11:22
@tonytw1
tonytw1 force-pushed the libvips-cropping branch 6 times, most recently from c916363 to dcd3779 Compare December 30, 2025 11:08
tonytw1 added 30 commits July 25, 2026 20:58
@tonytw1
[libvips-cropping] Allow embedded icc profile to be used in crop icc …
a9be3e7 
…transform.
@tonytw1
[libvips-cropping] Image operations resize takes the output file as a…
a849777 
… parameter for easier testing.
@tonytw1
[libvips-cropping] Cropping of LAB fixed by making non icc_transform …
82f93dd 
…decision based on no icc profile seen.

Nice and clean; cribbed from vips thumbnail source code.
@tonytw1
[libvips-cropping] Show that it is possible to manually trim metadata…
3af9d23 
… without relying in strip on save.

Leads to been able to set metadata on crops.
If not removed, orientation will express itself on save if not removed even though it's not in a exif prefixed field.
@tonytw1
[libvips-cropping] Bake the credit, copyright and supplier transmissi…
08c529c 
…on reference into the XMP using IPTC metadata fields.

Explicitly use compact XMP format.
IPTC has moved from the app13 block into XMP.
@tonytw1
XMP Credit -> photoshop:Credit
8101c40
@tonytw1
XMP Byline -> creator.
3c83537
@tonytw1
[libvips-cropping] While manually stripping metadata might be useful,…
75c2e63 
… vips strip with keep for XMP feels safer.
@tonytw1
[libvips-cropping] Use vip ffm 1.9.8 VImage set blob.
171a647
@tonytw1
[libvips-cropping] Additional resize tests.
a2c9647
@tonytw1
[libvips-cropping] Test for correct resize of png with alpha.
619b335
@tonytw1
[libvips-cropping] Provide an example of the vips can't render a LAB …
b331e7b 
…tiff with alpha correctly.
@tonytw1
[libvips-cropping] Cleanup; Lower the input of apiSource to imageId f…
6af7080 
…or outputFilename.
@tonytw1
[libvips-cropping] resizeImageVips does not need the MasterCrop object
23df659 
Because the dimensions of the source image needed to calculate the scale are direct available on the source VImage dimensions.
@tonytw1
[libvips-cropping] Metadata for crop call.
e5b89b5
@tonytw1
[libvips-cropping] Crop metadata in XMP via vips removes exiftool as …
63bf091 
…a dependency.
@tonytw1
[libvips-cropping] createCrops moves to image operations for testing.
35ac65f
@tonytw1
[libvips-cropping] Tests to exercise crops.
5ed639f
@tonytw1
[libvips-cropping] createCrops can execute it's resizeImage calls in …
1d660f1 
…parallel.

resizeImage is wrapped in a Future.
Multi thread cropping will need a shared Arena.
@tonytw1
[libvips-cropping] Master crop save in parallel.
96d3297
@tonytw1
[libvips-cropping] Logging.
1413683
@tonytw1
[libvips-cropping] Logging and imports.
ad46026
@tonytw1
[libvips-cropping] Do not send resizes until master has successfully …
9ea244d 
…rendered; don't want to send partial sets.
@tonytw1
[libvips-cropping] getImageInformation uses imageOperations.hasAlpha …
d792520 
…function
@tonytw1
[libvips-cropping] Missing arena.close()
8230d11
@tonytw1
[libvips-cropping] Crops uses master hasAlpha image operation rather …
04a0c85 
…than indexed metadata for crop type decision.

Makes this operation more self contained and fix forwardable.
@tonytw1
[libvips-cropping] Do not repeat calls to image_get_interpretation
094d246
@tonytw1
Removes exiftool from base image.
7b5edcf
@tonytw1
Remove pnquant from base image.
09eed43
@tonytw1
CropsTest - wait for Future before closing arena!
f393db1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tonytw1