chore(admin): #IMPULS-5854 uniformise le fichier de proxy de développement avec .env - #1051
Merged
damienromito merged 2 commits intoJun 22, 2026
Conversation
damienromito
force-pushed
the
tools-IMPULS-5854-uniformize-env-proxy-file
branch
from
June 19, 2026 09:08
50cfc84 to
a1da75e
Compare
damienromito
force-pushed
the
tools-IMPULS-5854-uniformize-env-proxy-file
branch
from
June 19, 2026 14:07
a1da75e to
077b969
Compare
jcbe-ode
reviewed
Jun 19, 2026
jcbe-ode
left a comment
jcbe-ode
left a comment
Contributor
There was a problem hiding this comment.
Ca parait OK
- petite amélioration du code suggérée au passage.
| PROXY_FAVICO.target = target; | ||
| if (oneSessionId && xsrfToken) { | ||
| PROXY_CONFIG.headers = { | ||
| cookie: `oneSessionId=${oneSessionId}; authenticated=true; XSRF-TOKEN=${xsrfToken}`, |
Contributor
There was a problem hiding this comment.
Suggested change
| cookie: `oneSessionId=${oneSessionId}; authenticated=true; XSRF-TOKEN=${xsrfToken}`, | |
| cookie: `oneSessionId=${env.VITE_ONE_SESSION_ID}; authenticated=true; XSRF-TOKEN=${xsrfToken}`, |
Contributor
There was a problem hiding this comment.
Les variables intermédiaires oneSessionId, xsrfToken et target complexifient la lecture, je trouve.
On pourrait utiliser directement env ?
Ou bien la désérialiser ?
const {VITE_RECETTE, VITE_XSRF_TOKEN, VITE_ONE_SESSION_ID} = env;
vbillard91
force-pushed
the
develop-b2school
branch
from
June 22, 2026 09:18
1a3d94c to
684bb30
Compare
damienromito
force-pushed
the
tools-IMPULS-5854-uniformize-env-proxy-file
branch
from
June 22, 2026 09:31
bcf2a6e to
850c67f
Compare
|
jcbe-ode
pushed a commit
that referenced
this pull request
Jun 22, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
juniorode
pushed a commit
that referenced
this pull request
Jun 22, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Jun 23, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
jcbe-ode
pushed a commit
that referenced
this pull request
Jun 23, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Jun 24, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
damienromito
added a commit
that referenced
this pull request
Jun 24, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
pb-jo
pushed a commit
that referenced
this pull request
Jun 25, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
jcbe-ode
pushed a commit
that referenced
this pull request
Jun 25, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
damienromito
added a commit
that referenced
this pull request
Jun 29, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Jun 30, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Jul 3, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
jcbe-ode
pushed a commit
that referenced
this pull request
Jul 3, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
vbillard91
pushed a commit
that referenced
this pull request
Jul 6, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
jenkinsEdificePublic
pushed a commit
that referenced
this pull request
Jul 7, 2026
…ement avec .env (#1051) * chore(admin):#IMPULS-5854 uniformise env proxy file * simplify from review comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uniformise la configuration du proxy de développement d'Admin avec le reste des frontends Edifice en remplaçant le fichier
.proxyRemoteConfig.js(propre à Angular/Admin) par un fichier.envstandard (VITE_RECETTE / VITE_XSRF_TOKEN / VITE_ONE_SESSION_ID).Cela permet à
dev-auth-fetcherde gérer Admin comme n'importe quel autre frontend et de générer son fichier de credentials automatiquement. (voir PR edificeio/dev-auth-fetcher#4)Fixes
IMPULS-5854
Type of change
Which packages changed?
Tests
admin/src/main/ts/.envà partir de.env.templateen renseignantVITE_RECETTE,VITE_XSRF_TOKENetVITE_ONE_SESSION_IDng serveUsing remote proxy configuration target: <url>s'afficheAlternativement : utiliser
dev-auth-fetcher connect— Admin apparaît désormais dans la liste des apps et le.envest généré automatiquement.Reminder
Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃