fix(session): reuse eventstore when getting session through nats#1029
Open
nabil-mansouri wants to merge 3 commits into
Open
fix(session): reuse eventstore when getting session through nats#1029nabil-mansouri wants to merge 3 commits into
nabil-mansouri wants to merge 3 commits into
Conversation
nabil-mansouri
force-pushed
the
fix-session
branch
3 times, most recently
from
May 28, 2026 16:56
84966db to
408410f
Compare
nabil-mansouri
force-pushed
the
fix-session
branch
3 times, most recently
from
May 28, 2026 17:06
72c645a to
d20aa2f
Compare
nabil-mansouri
force-pushed
the
fix-session
branch
from
May 28, 2026 17:07
d20aa2f to
4da7c28
Compare
|
juniorode
reviewed
May 29, 2026
juniorode
left a comment
juniorode
left a comment
Contributor
There was a problem hiding this comment.
OK modulo les versions des dépendances
Member
|
Oui, vu que la PR est sur master, il n'aurait fallu commit que le java. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ce fix permet de réutiliser les eventstore et éviter l'instanciation de pool pg
Fixes
(Enter here Jira or Redmine ticket(s) links)
Type of change
Please check options that are relevant.
Which packages changed?
Please check the name of the package you changed
Tests
Reminder
Security flaws
Performance impacts (think bulk !)
Unit tests were replayed
Unit tests were added and/or changed
I have updated the reminder for the version including my modifications
All done ! 😃