Skip to content

fix: harden module parsers against malformed input #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azenla merged 2 commits into from
Jun 30, 2026
Merged

fix: harden module parsers against malformed input #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01fc56b
fix(signature): prevent underflow panic on malformed signatures
azenla Jun 30, 2026
885c0a6
fix(object): bounds-check e_ident before reading ELF header
azenla Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/object/content.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ impl KernelObjectContent {
return false;
}

// Need at least the e_ident fields read below (EI_CLASS, EI_DATA, EI_VERSION).
if self.bytes.len() < 7 {
return false;
}

// Byte 5: EI_CLASS, 0x1 = 32-bit, 0x2 = 64-bit module
if self.bytes[4] != 1 && self.bytes[4] != 2 {
return false;
Expand Down
6 changes: 4 additions & 2 deletions src/signature/raw.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,10 @@ impl RawKernelObjectSignature {
let header = bytemuck::try_pod_read_unaligned::<RawKernelObjectSignatureHeader>(header)
.map_err(Error::DataDecodeError)?;
let signature_length = header.signature_length() as usize;
let total_length =
signature_length + header.signer_length as usize + header.key_id_length as usize;
let total_length = signature_length
+ header.signer_length as usize
+ header.key_id_length as usize
+ size_of::<RawKernelObjectSignatureHeader>();
if signature_length == 0 || (total_length > before_magic.len()) {
return Ok(Some(RawKernelObjectSignature {
header,
Expand Down
Loading