feat(build): sbom#12
Merged
Merged
Conversation
Contributor
Author
|
bleggett
approved these changes
Jun 26, 2026
Contributor
There was a problem hiding this comment.
Approving but we should actually gut this and its dependence on external C tools and just invoke sudo edera-check collect which collects the same info without external vendored binaries.
Comment on lines
+4
to
+10
| The image is `FROM scratch` and ships, under /var/lib/edera/protect/support/: | ||
| - bin/dmidecode statically-linked C binary (submodule extern/dmidecode) | ||
| - bin/lspci, update-pciids statically-linked C binaries (submodule extern/pciutils) | ||
| - hwdata/pci.ids.gz PCI id database bundled with pciutils | ||
| - edera-debug-report the stdlib-only Python driver script (this repo) | ||
| - README.md | ||
|
|
Contributor
There was a problem hiding this comment.
This is another reason why we should just make this a script wrapper around
sudo edera-check collect - we collect the same DMI/lspci info there but with native Rust code and so we don't need to SBOM random in-tree CI binaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.