Fix Play Protect flag (drop All-files access) and Focus wake-lock leak - #4
Merged
Conversation
Remove MANAGE_EXTERNAL_STORAGE (and legacy WRITE_EXTERNAL_STORAGE / requestLegacyExternalStorage), which was getting installs flagged as harmful by Google Play Protect. The blockade ledger now survives uninstall/reinstall via Android Auto Backup rather than a shared-storage mirror, so no storage permission is requested at all. Fix Focus mode keeping the whole device awake forever: keep-awake was set on the shared root view and only released by FocusScreen's onDispose, so it leaked when the composable never disposed (e.g. HOME press while Tempo isn't the default launcher). Drive FLAG_KEEP_SCREEN_ON from the Focus screen state in TempoApp instead, clearing it on every other screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes ahead of v0.0.9:
MANAGE_EXTERNAL_STORAGE(All-files access). This permission was causing Google Play Protect to flag installs as harmful and block installation on many devices — a launcher has no need for device-wide file access. LegacyWRITE_EXTERNAL_STORAGEandrequestLegacyExternalStorageare removed too, so Tempo now requests no storage permission. The 10-day blockade ledger survives uninstall/reinstall via Android Auto Backup (cloud restore) instead of a shared-storage mirror.FocusScreen'sonDispose, so it leaked whenever the composable never disposed (e.g. pressing HOME while Tempo isn't the default launcher) — the display stayed awake forever, even on Home.FLAG_KEEP_SCREEN_ONis now driven from the Focus screen state inTempoAppand cleared on every other screen.Notes
build.gradlebump needed.Test plan
./gradlew :app:compileDebugKotlin— passes.