earthmover_cmd refactor [EDFIAL-466] - #92
Merged
Merged
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
johncmerfeld
reviewed
Jul 7, 2026
| if em.stderr: | ||
| self.logger.info(f"earthmover stderr: {em.stderr}") | ||
|
|
||
| return em |
Collaborator
There was a problem hiding this comment.
Wondering if we should just include em.check_returncode() in this function so we don't have to remember to do it after every invocation?
Collaborator
Author
There was a problem hiding this comment.
Agree that we should. Just updated to include and removed the standalone calls
johncmerfeld
approved these changes
Jul 8, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for 466
earthmover_cmdmethod to encapsulate earthmover calls and loggingearthmover_depsto callearthmover_cmdearthmover_runto callearthmover_cmd