Skip to content

[Snyk] Fix for 9 vulnerabilities - #88

Merged
edandylytics merged 4 commits into
developmentfrom
snyk-fix-b9857a01675c6995288cef996c6525f0
Jul 21, 2026
Merged

[Snyk] Fix for 9 vulnerabilities#88
edandylytics merged 4 commits into
developmentfrom
snyk-fix-b9857a01675c6995288cef996c6525f0

Conversation

@snyk-io-us

@snyk-io-us snyk-io-us Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

snyk-top-banner

Snyk has created this PR to fix 9 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • app/package.json
  • app/package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-7925106
  666  
high severity Asymmetric Resource Consumption (Amplification)
SNYK-JS-BODYPARSER-7926860
  624  
medium severity Exposed Dangerous Method or Function
SNYK-JS-NX-17660796
  586  
medium severity Arbitrary Code Injection
SNYK-JS-NESTJSCOMMON-9538801
  561  
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  559  
medium severity Cross-site Scripting (XSS)
SNYK-JS-COOKIE-8163060
  529  
medium severity Cross-site Scripting
SNYK-JS-EXPRESS-7926867
  469  
low severity Cross-site Scripting
SNYK-JS-SEND-7926862
  319  
low severity Cross-site Scripting
SNYK-JS-SERVESTATIC-7926865
  319  

Breaking Change Risk

Merge Risk: High

Notice: This assessment is enhanced by AI.


Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Cross-site Scripting (XSS)
🦉 Prototype Pollution
🦉 Arbitrary Code Injection
🦉 More lessons are available in Snyk Learn

@snyk-io-us

snyk-io-us Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Merge Risk: High

This set of upgrades includes two major version bumps with significant breaking changes, requiring developer action and verification.

Top 3 Most Impactful Upgrades:

  • @nx/nest 19.3.220.0.0 (HIGH RISK)
    This major upgrade introduces a fundamental breaking change by deprecating the @nrwl scope in favor of the @nx scope for all packages. [3, 6] This migration is manual and requires developers to update all imports and configuration files (e.g., changing @nrwl/nest to @nx/nest). [3] Automatic migration for this scope change is not provided. [3] Additionally, generators no longer use derived directories and now require explicit directory paths. [3]

    Recommendation: Before merging, manually search and replace all instances of @nrwl/ with @nx/ in your repository's configuration and source files. Review any custom scripts that use Nx generators.

  • @nestjs/config 3.2.34.0.3 (MEDIUM RISK)
    This major upgrade alters the precedence of configuration sources. Previously, environment variables (process.env) would override values from custom configuration files. In v4, the order is reversed: internal configuration (e.g., custom config files) now takes precedence over environment variables. [2, 4] This could silently alter your application's behavior in different environments if you rely on .env files to override settings from config files.

    Recommendation: Verify your application's configuration loading strategy, especially in production-like environments, to ensure variables are loaded with the correct precedence.

  • @nestjs/common, @nestjs/core, @nestjs/platform-express (LOW RISK)
    These minor upgrades from 10.3.10 to 10.4.x are part of the NestJS v10 ecosystem and primarily include feature enhancements and bug fixes. No significant breaking changes are documented for this minor version span.

Other Upgrades:

  • lodash 4.17.214.17.23 (low): This patch update includes security fixes. [4]
  • @nestjs/swagger 7.4.07.4.1 (low): A patch release, likely containing minor bug fixes.
  • express-session 1.18.01.18.1 (low): A patch release with no documented breaking changes.

Notice 🤖: This content was augmented using artificial intelligence. AI-generated content may contain errors and should be reviewed for accuracy before use.

@amazon-inspector-ohio

Copy link
Copy Markdown

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@snyk-io-us

snyk-io-us Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Snyk checks have failed. 4 issues have been found so far.

Status Scan Engine Critical High Medium Low Total (4)
Open Source Security 0 1 3 0 4 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@amazon-inspector-ohio

Copy link
Copy Markdown

✅ I finished the code review, and didn't find any security or code quality issues.

@edandylytics
edandylytics self-requested a review June 30, 2026 17:48
Comment thread app/package.json Outdated
@edandylytics

edandylytics commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Package-by-package analysis, updated as I go:

  • @nx/nest 19.3.2 → 20.0.0
    • AK: decided to remove as we're not using generators any more.
  • @nestjs/config 3.2.3 → 4.0.3
    • AK: we use it, needs to stay. release notes
      • we don't use config files, so .get precedence changes don't impact runway
      • we don't use deprecated ignoreEnvVars
  • @nestjs/common, @nestjs/core. @nestjs/platform-express
    • Snyk upgraded these to different versions, but I think it'd be better to use the same version for each package -- I expect nest folks actually test packages all on the same version and not across different combos. 10.4.22 looks good.
    • The upgrade to 10.4.22 introduced 4 issues that cannot be fixed without an upgrade to nest v11. Runway isn't impacted by them and we do resolve a number of other issues with the upgrades to 10.4.22, so I think that's worth it..
  • lodash 4.17.21 → 4.17.23 (low)
    • not seeing docs on the patches, but it's just a couple patches and lodash
    • should we go to 4.18.1? Looks like _.template (which we don't use) has a vulnerability still.
    • We'll do 4.18.1, but will also need to bump @nestjs/config to 4.0.4 :/
    • @nestjs/swagger will continue to use an older pinned version, but we'll be doing a major version upgrade of that in a separate pr anyway.
  • @nestjs/swagger 7.4.0 → 7.4.1 (low)
    • AK: fine. We just use @ApiTag and similar decorators and in dev envs build Swagger docs. Looks like [Snyk] Fix for 1 vulnerabilities #93 will have us looking at this package again, though. It (unhelpfully) pins lodash 4.17.21.
  • express-session 1.18.0 → 1.18.1 (low)
    • AK: use it, single patch that fixes a CVE.

@edandylytics
edandylytics requested a review from rtavernaea July 17, 2026 21:46
@edandylytics

Copy link
Copy Markdown
Collaborator

@rtavernaea I made enough updates here that I really shouldn't be the reviewer. Could you take a look?

@rtavernaea

Copy link
Copy Markdown
Collaborator
  • The upgrade to 10.4.22 introduced 4 issues that cannot be fixed without an upgrade to nest v11

Will these be addressed in the same upgrade you mentioned we'll be doing a separate PR for (referring to @nestjs/swagger)?

@edandylytics

Copy link
Copy Markdown
Collaborator

Will these be addressed in the same upgrade you mentioned we'll be doing a separate PR for (referring to @nestjs/swagger)?

@rtavernaea I'm not sure yet. I think taking the upgrade in this PR is good as it resolves more issues than it introduces and Runway's not impacted by any of the newly introduced issues. An upgrade of Nest to v11 would be a big undertaking and we'd need to determine whether/when it's worth it. I don't think resolving these specific new issues is worth it, but there could be other reasons.

@edandylytics
edandylytics merged commit d937455 into development Jul 21, 2026
9 checks passed
@edandylytics
edandylytics deleted the snyk-fix-b9857a01675c6995288cef996c6525f0 branch July 21, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants