Skip to content

Fix/em command logging - #101

Merged
johncmerfeld merged 10 commits into
developmentfrom
fix/em_command_logging
Jul 16, 2026
Merged

Fix/em command logging#101
johncmerfeld merged 10 commits into
developmentfrom
fix/em_command_logging

Conversation

@theokaufman

Copy link
Copy Markdown
Collaborator

When our stacktrace gets above a certain size (8kb), the WAF blocks the POST and we don't report any stacktrace on the frontend.

This change limits stacktrace size to 6kb, so we don't run into this failure mode and always report a stacktrace (even if it's truncated)

@amazon-inspector-ohio

Copy link
Copy Markdown

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@snyk-io-us

snyk-io-us Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@theokaufman
theokaufman requested a review from johncmerfeld July 16, 2026 22:25
@amazon-inspector-ohio

Copy link
Copy Markdown

✅ I finished the code review, and didn't find any security or code quality issues.

@johncmerfeld
johncmerfeld merged commit b2dce41 into development Jul 16, 2026
4 checks passed
@edandylytics edandylytics mentioned this pull request Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants