Add course characteristics to dim_course - #245
Merged
Merged
Conversation
Collaborator
|
marking for 0.7.0 so it can be aligned with release of #231. Very likely to be released ~August |
rlittle08
approved these changes
Jul 30, 2026
rlittle08
left a comment
Collaborator
There was a problem hiding this comment.
i had to add a bld model at the course level to avoid grain issues with the join in dim_course -- to get ahead of this in the future, you can always run a e.g. dbt test -s dim_course on the models you're editing to double-check ref integrity while testing the change
after my change here, the result looks good in boston with tests passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation
This PR would add a course charactersitics array to the
dim_coursemodel. This array already exists in the course section model, but would now be surfaced at the course level as well. Addresses this Boston Monday item.Breaking changes introduced by this PR:
No breaking changes.
PR Merge Priority:
Changes to existing files:
dim_course: Add course level characteristics arrayNew files created:
Tests and QC done:
stadium_bostonedu_wh PR Review Checklist:
Make sure the following have been completed before approving this PR:
## New Featuresfor features, etc.