Feature/lightbeam delete dag - #86
Conversation
jayckaiser
left a comment
There was a problem hiding this comment.
The code is beautiful. It brings a tear to my eye. I look forward to giving this a shot in South Carolina!
|
I realized that the accident-prevention step of requiring at least one query parameter isn't very strong. If you have a typo in the key, such as |
|
Added a fail-safe task that checks whether all of the records will be deleted from any resource. This guards against the possibility of no valid query parameters being passed (due to a typo in the query key, for example) and all records being returned for deletion. However this also means that if there is only one assessment in an ODS, for example, the DAG cannot delete it. I think this is a reasonable safety measure but am definitely open to other ideas. |
No description provided.