Skip to content

Feature/lightbeam delete dag - #86

Open
sleblanc23 wants to merge 9 commits into
mainfrom
feature/lightbeam_delete_dag
Open

Feature/lightbeam delete dag#86
sleblanc23 wants to merge 9 commits into
mainfrom
feature/lightbeam_delete_dag

Conversation

@sleblanc23

Copy link
Copy Markdown
Contributor

No description provided.

@sleblanc23

Copy link
Copy Markdown
Contributor Author

@jayckaiser jayckaiser left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is beautiful. It brings a tear to my eye. I look forward to giving this a shot in South Carolina!

@sleblanc23

Copy link
Copy Markdown
Contributor Author

I realized that the accident-prevention step of requiring at least one query parameter isn't very strong. If you have a typo in the key, such as "aaaaassessmentIdentifier": "NWEA-Map", it will fetch and subsequently delete all records from the resource. I think we should put some limits on this before it's released, perhaps requiring at least an assessmentIdentifier parameter.

@sleblanc23

Copy link
Copy Markdown
Contributor Author

Added a fail-safe task that checks whether all of the records will be deleted from any resource. This guards against the possibility of no valid query parameters being passed (due to a typo in the query key, for example) and all records being returned for deletion. However this also means that if there is only one assessment in an ODS, for example, the DAG cannot delete it. I think this is a reasonable safety measure but am definitely open to other ideas.

@sleblanc23
sleblanc23 marked this pull request as ready for review August 6, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants