Skip to content

Hotfix: Replace logical_date with dag_run.start_date #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jayckaiser wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Hotfix: Replace logical_date with dag_run.start_date #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7a0c300
First pass at replacing ds/ts with dag_run.start_date equivalents.
jayckaiser Jul 29, 2026
7b31991
Revert updates made in log_util (out of scope in deprecated DAG).
jayckaiser Jul 29, 2026
93a1fd5
Actual reversion of previous commit.
jayckaiser Jul 29, 2026
219a9cb
Add missing whitespace to complete revert.
jayckaiser Jul 29, 2026
e4b0fca
Revert documentation changes in deprecated provider.
jayckaiser Jul 29, 2026
a8d20ed
Fix datetype string representation in helpers.
jayckaiser Jul 29, 2026
8c8d265
Bugfix: method mispelling.
jayckaiser Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion edu_edfi_airflow/callables/change_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ def update_change_versions(
for endpoint in endpoints:
row = [
tenant_code, api_year, endpoint,
context["ds"], context["ts"],
context["dag_run"].start_date.date().isoformat(), context['dag_run'].start_date.isoformat(),
edfi_change_version, True,
row_set["get_deletes"],
]
Expand Down
2 changes: 1 addition & 1 deletion edu_edfi_airflow/callables/total_counts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def insert_total_counts(
for endpoint in endpoint_counts:
row = [
tenant_code, api_year, endpoint[0],
kwargs["ds"], kwargs["ts"],
kwargs["dag_run"].start_date.date().isoformat(), kwargs['dag_run'].start_date.isoformat(),
endpoint[1]
]
rows_to_insert.append(row)
Expand Down
2 changes: 1 addition & 1 deletion edu_edfi_airflow/dags/edfi_resource_dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def chain_task_groups_into_dag(self):

# Set parent directory and create subfolders for each task group.
parent_directory = os.path.join(
self.tenant_code, str(self.api_year), "{{ ds_nodash }}", "{{ ts_nodash }}"
self.tenant_code, str(self.api_year), "{{ dag_run.start_date | ds_nodash }}", "{{ dag_run.start_date | ts_nodash }}"
)

# Resources
Expand Down