Skip to content

Blink parity: do not add a trailing newline to inline-HTML-ending files #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 5, 2026
Merged

Blink parity: do not add a trailing newline to inline-HTML-ending files #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions blink/internal/fixer/rules/rules_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,4 +381,12 @@ func TestSingleBlankLineAtEndOfFile(t *testing.T) {
if _, changed := apply(t, SingleBlankLineAtEndOfFile{}, "<?php echo 1;\n"); changed {
t.Fatal("single newline should not change")
}
// a file ending in inline HTML gets no trailing newline added (php-cs-fixer
// skips T_INLINE_HTML / T_CLOSE_TAG endings)
if _, changed := apply(t, SingleBlankLineAtEndOfFile{}, "<?php echo 1; ?>\n</html>"); changed {
t.Fatal("inline-HTML ending must be left alone")
}
if _, changed := apply(t, SingleBlankLineAtEndOfFile{}, "<?php echo 1; ?>"); changed {
t.Fatal("close-tag ending must be left alone")
}
}
5 changes: 5 additions & 0 deletions blink/internal/fixer/rules/single_blank_line_at_eof.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ func (SingleBlankLineAtEndOfFile) Fix(s *tokens.Stream) bool {
}
last := s.Len() - 1
t := s.At(last)
// a file ending in inline HTML or a tag is left alone (php-cs-fixer skips
// T_INLINE_HTML / T_CLOSE_TAG / T_OPEN_TAG), so a template keeps its ending
if t.Kind == token.InlineHTML || t.Kind == token.CloseTag || t.Kind == token.OpenTag {
return false
}
if t.Kind == token.Whitespace {
// the final whitespace token is entirely trailing; collapse to one \n
if t.Value != "\n" {
Expand Down
Loading