Repository navigation
Blink parity: break outer opener for call/new-wrapped nested arrays; gate to 0.3% - #138
Merged
Merged
Conversation
…or new
Extends the nested-array opener break to an enclosing list whose last element
wraps the associative array in a call, "new" or further arrays
("[createFilter([assoc])]", "[new Request(..., [assoc])]"). Walk outward
through those wrappers, breaking the opener of every plain list whose last
content is the assoc being expanded, matching ECS.
TomasVotruba
force-pushed
the
tv-blink-parity-nest2
branch
2 times, most recently
from
October 5, 2026 09:53
474c9d6 to
c74db6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the nested-array outer-opener break to call- and new-wrapped arrays. Measured drop: 15 to 12 differing files of 4527 (0.27%), 3 files fixed with zero regressions.
Note: stacked on #137 (collapse blank lines between call/parameter arguments). Review/merge #137 first; this rebases to a single commit after.
The pattern
Same outer-list-opener break as #135, but the enclosing list's element is itself an array or a call wrapping the associative array, so #135's "first element not an array" guard excluded it:
blink previously kept
willReturn([$this->createFilter([on the opener line. Same fornew RequestStack([new Request([...])]).The fix
enclosingListsForExpandedAssocwalks outward from the expanded associative array through call parens,new, and nested brackets, breaking the opener of every plain list whose last content (through that wrapper chain) is the assoc being expanded. Keeps both upstream guards per list (first element not itself an array; opener not already broken). Only the opener breaks (closer stays joined])]);). Subsumes #135's direct case.Gate
MAX_DIFF_PERCENTlowered 0.4 to 0.3; actual is 0.27% (12 of 4527).Fixed: DynamicFiltersTypeTest, InjectCustomContentSubscriberTest, GrapesJsBuilderModelEditorStateTest. Unit tests cover call-wrapped, new-wrapped, and the first-element-is-array no-op. Full blink suite, go vet, golangci-lint green; strict rector-src 1:1 gate stays 0-diff.