Repository navigation
Blink parity: split shared-line commas in multiline arrays - #133
Merged
Merged
Conversation
A multiline associative array could still carry a top-level comma that
shared its line with the next item ("], 'attr' => ["). ArrayListItemNewline
skipped multiline arrays entirely; now it breaks each such comma (Symplify
ArrayItemNewliner behavior), leaving array_indentation to align them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One array-reflow parity fix on mautic/mautic. Measured drop: 40 to 37 differing files of 4527 (0.82%).
A multiline associative array could still carry a top-level comma sharing its line with the next item:
ArrayListItemNewline skipped already-multiline arrays entirely, so such a comma was never broken. It now breaks each top-level comma that still shares its line (matching Symplify's ArrayItemNewliner), leaving array_indentation to align the result. Comments and
{after a comma are left alone, and a comma already followed by a newline is untouched.Unit test covers the split; full blink suite, go vet and golangci-lint are green.