Repository navigation
Fix flaky check-sources and parity gate PHP-engine abort - #128
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI fixes that landed just after #127 was squash-merged, so they missed it.
check-sources: retry on GitHub throttling
cmd/check-sourcesfires ~200 HEAD requests at GitHub in a burst; GitHub rate-limits with 503/429, failing thefixer_sourcesjob even though every URL is valid. Now retries 5xx/429 with backoff, sends a User-Agent, and throttles the burst. A genuine 4xx (renamed/removed source) still fails immediately.blink parity gate: run the PHP engine single-process
The
blink-parity-mauticjob ran the PHP engine (the reference side) with ECS parallel workers. On large mautic files the worker result overflows the NDJSON decoder buffer (clue/ndjson-react: "Buffer size exceeded"), hits the 50 system-error limit, and aborts half-fixed - so fully-fixed blink looked ~63% divergent. Added->withoutParallel()to the gate's ECS config; the PHP engine now completes and true parity (~1.6%) is measured. blink is a Go binary and ignores the flag.Also adds a
blink/.gitignorefor the built binaries.