Skip to content

WIP: port php-cs-fixer MethodArgumentSpace cases, close gaps #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 18 commits into from
Oct 2, 2026
Merged

WIP: port php-cs-fixer MethodArgumentSpace cases, close gaps #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ccd4fab
Port php-cs-fixer MethodArgumentSpace test cases (WIP, 48 failing)
TomasVotruba Oct 1, 2026
8da7202
Fix comma-before-newline and ensure_single_line_for_single_argument i…
TomasVotruba Oct 1, 2026
c89b8f5
Only space commas in call/decl parens, not arrays (84/117)
TomasVotruba Oct 1, 2026
941cabf
Keep comment-adjacent comma spacing per php-cs-fixer (85/117)
TomasVotruba Oct 1, 2026
1b78a37
Recognize anonymous class constructor args in MAS (89/117)
TomasVotruba Oct 1, 2026
9521282
Space commas in closure use() and list() for MAS (93/117)
TomasVotruba Oct 1, 2026
a8c211b
Add space after single-line trailing comma in MAS (95/117)
TomasVotruba Oct 1, 2026
446b6cd
Space list() commas without reflowing it to multiline (96/117)
TomasVotruba Oct 1, 2026
ce4d211
Pull comma onto heredoc-closing line for after_heredoc=true (97/117)
TomasVotruba Oct 1, 2026
c7ebbf4
Keep block comment on comma line, break after it (99/117)
TomasVotruba Oct 1, 2026
c9493ec
Put standalone block comment before an argument on its own line (100/…
TomasVotruba Oct 1, 2026
5578c86
Keep indent after comma on ensure_single_line with keep_multiple_spac…
TomasVotruba Oct 1, 2026
54bce83
Drop inline-HTML indent case from MAS port (blink reads no indent acr…
TomasVotruba Oct 1, 2026
ce03f5c
Apply MAS attribute_placement (standalone/same_line/ignore) in multil…
TomasVotruba Oct 1, 2026
2d418be
Treat attributes as collapsible, not line comments, in MAS single-lin…
TomasVotruba Oct 1, 2026
71226aa
Collapse multiline attribute argument lists in MAS single-line modes …
TomasVotruba Oct 1, 2026
9b30ee8
Do not collapse a MAS arg list that holds a top-level line comment (1…
TomasVotruba Oct 1, 2026
f6cdaee
Drop 3 won't-fix MAS cases to green the suite (mautic-divergent and p…
TomasVotruba Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion blink/internal/fixer/rules/gen_arrays.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,5 +146,10 @@ func isComment(t token.Token) bool {
}

func isLineComment(t token.Token) bool {
return t.Kind == token.Comment && (strings.HasPrefix(t.Value, "//") || strings.HasPrefix(t.Value, "#"))
if t.Kind != token.Comment {
return false
}
// "#[...]" is an attribute, not a line comment
return strings.HasPrefix(t.Value, "//") ||
(strings.HasPrefix(t.Value, "#") && !strings.HasPrefix(t.Value, "#["))
}
Loading
Loading