Fix gossip scouting for loopback locators - #2755
Open
fuzzypixelz wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2755 +/- ##
==========================================
- Coverage 74.70% 74.70% -0.01%
==========================================
Files 419 419
Lines 63825 63820 -5
==========================================
- Hits 47681 47675 -6
- Misses 16144 16145 +1 ☔ View full report in Codecov by Harness. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes a regression introduced in #2671: loopback locators were no longer being sent during gossip scouting.
What does this PR do?
This patch restores the old scouting behavior where loopback locators were filtered out only if they originate in unspecified endpoints.
I've also caught an inadvertant change of behavior in
SessionInfo::locatorsintroduced in #2671, where said method started returning the aforementioned loopback locators originating in unspecified endpoints.Related Issues
Fixes #2753.
🏷️ Label-Based Checklist
Based on the labels applied to this PR, please complete these additional requirements:
Labels:
bug🐛 Bug Fix Requirements
Since this PR is labeled as a bug fix, please ensure:
Why this matters: Bugs without tests often reoccur.
Instructions:
- [ ]to- [x])This checklist updates automatically when labels change, but preserves your checked boxes.