fix: parse standard UUID text representation - #1272
Open
tianrking wants to merge 1 commit into
Open
Conversation
Signed-off-by: tianrking <10758833+tianrking@users.noreply.github.com>
tianrking
marked this pull request as draft
July 26, 2026 17:27
tianrking
marked this pull request as ready for review
July 26, 2026 17:41
tianrking
marked this pull request as draft
July 26, 2026 18:05
tianrking
marked this pull request as ready for review
July 26, 2026 18:06
Contributor
|
Hello @tianrking . Thanks for your contribution. Could you please sign eclipse eca https://www.eclipse.org/legal/eca/? |
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
8-4-4-4-12).00112233-4455-6677-8899-aabbccddeeffto the expected 16 bytes.Why is this change needed?
The parser skipped the last dash two characters too early, so standard UUID strings were decoded with incorrect bytes. This restores compatibility with RFC-style UUID strings used by other libraries and configuration producers.
Validation
z_utils_testtarget with CMake/Ninja and MSVC.z_utils_test.exesuccessfully.ctest -R '^z_utils_test$' --output-on-failure— 1/1 passed.Related Issues
Fixes #1229.
Development disclosure
OpenAI Codex assisted with the implementation and test development. The patch was independently cross-reviewed and validated with MSVC as well as a GCC/AddressSanitizer test run.
🏷️ Label-Based Checklist
Based on the labels applied to this PR, please complete these additional requirements:
Labels:
bug🐛 Bug Fix Requirements
Since this PR is labeled as a bug fix, please ensure:
Why this matters: Bugs without tests often reoccur.
Instructions:
- [ ]to- [x])This checklist updates automatically when labels change, but preserves your checked boxes.