Reconnect to the last endpoint without restarting tasks - #1220
Open
steils wants to merge 1 commit into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| LIVELINESS_SUB_CLIENT_COMMAND = STDBUF_CMD + [f'{DIR_EXAMPLES}/z_sub_liveliness', '-h', '-e', f'tcp/127.0.0.1:{ZENOH_PORT}'] | ||
|
|
||
| SINGLE_THREAD_ZENOH_PORT = "7448" | ||
| SINGLE_THREAD_ROUTER_ARGS = ['-l', f'tcp/0.0.0.0:{SINGLE_THREAD_ZENOH_PORT}', '--no-multicast-scouting'] |
There was a problem hiding this comment.
Cppcheck (reported by Codacy) found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
steils
changed the title
steils
changed the title
steils
force-pushed
the
reconnection
branch
2 times, most recently
from
May 13, 2026 15:30
631df0d to
3da94d4
Compare
steils
marked this pull request as ready for review
May 13, 2026 16:05
gmartin82
suggested changes
May 14, 2026
gmartin82
reviewed
May 14, 2026
Contributor
|
Does this change make #1205 unnecessary since that PR is about adressing tx resource usage while reconenction is active? |
steils
marked this pull request as draft
May 15, 2026 20:32
Member
Author
For the reconnect case is covered in this PR, I think yes, it's no longer needed. But as I see #1205 touches more general clear paths, so that still should be relevant after this PR. |
gmartin82
suggested changes
May 19, 2026
gmartin82
reviewed
May 19, 2026
steils
marked this pull request as draft
May 20, 2026 12:44
steils
force-pushed
the
reconnection
branch
4 times, most recently
from
May 25, 2026 04:40
c7ca57b to
99ba7d1
Compare
Avoid restarting transport tasks during client reconnect. Reuse the existing client transport and try the last successful endpoint first. If that fails, continue with the configured connect locators or scouted locators. Restore the connection without replacing the transport object. Closes: eclipse-zenoh#1005 Closes: eclipse-zenoh#1053
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid restarting transport tasks during client reconnect.
Reuse the existing client transport and try the last successful endpoint first.
If that fails, continue with the configured connect locators or scouted locators. Restore the connection without replacing the transport object.
Closes: #1005
Closes: #1053
🏷️ Label-Based Checklist
Based on the labels applied to this PR, please complete these additional requirements:
Labels:
enhancement✨ Enhancement Requirements
Since this PR enhances existing functionality:
Remember: Enhancements should not introduce new APIs or breaking changes.
Instructions:
- [ ]to- [x])This checklist updates automatically when labels change, but preserves your checked boxes.