Skip to content

Make a context project optional for EclipseRunMojo #5208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HannesWell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make a context project optional for EclipseRunMojo #5208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tycho-eclipse-plugin/src/main/java/org/eclipse/tycho/eclipserun/EclipseRunMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
* Launch an eclipse process with arbitrary commandline arguments. The eclipse
* installation is defined by the dependencies to bundles specified.
*/
@Mojo(name = "eclipse-run", threadSafe = true)
@Mojo(name = "eclipse-run", threadSafe = true, requiresProject = false)
public class EclipseRunMojo extends AbstractMojo {

/**
Expand Down Expand Up @@ -446,7 +446,7 @@ public LaunchConfiguration createCommandLine(EquinoxInstallation runtime) throws
+ ". Current Java runtime will be used");
}
cli.setJvmExecutable(executable);
cli.setWorkingDirectory(project.getBasedir());
cli.setWorkingDirectory(project.getBasedir() != null ? project.getBasedir() : new File("").getAbsoluteFile());

cli.addVMArguments(splitArgLine(argLine));
if (jvmArgs != null) {
Expand Down
4 changes: 2 additions & 2 deletions ...itory-plugin/src/main/java/org/eclipse/tycho/plugins/p2/repository/Repo2RunnableMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
* Mojo that provides the "repo2runnable" functionality described
* <a href="https://wiki.eclipse.org/Equinox/p2/Ant_Tasks#Repo2Runnable">here</a>.
*/
@Mojo(name = "repo-to-runnable")
@Mojo(name = "repo-to-runnable", requiresProject = false)
public class Repo2RunnableMojo extends AbstractMojo {

@Component
Expand Down Expand Up @@ -60,7 +60,7 @@ public void execute() throws MojoExecutionException, MojoFailureException {
try {
repo2Runnable.run(null);
} catch (ProvisionException e) {
throw new MojoFailureException(e);
throw new MojoExecutionException(e);
}
}

Expand Down
Loading