Update to Maven 4 by laeubi · Pull Request #4219 · eclipse-tycho/tycho

laeubi · 2024-09-08T17:19:01Z

This is to keep track of update to Maven 4

Tycho compiles with Maven 4
Tycho runs with Maven 4

Required cleanup PRs:

github-actions · 2024-09-08T17:22:09Z

Test Results

294 files - 774 294 suites - 774 10m 1s ⏱️ - 4h 57m 57s
644 tests - 777 588 ✅ - 812 42 💤 +21 6 ❌ + 6 8 🔥 + 8
1 932 runs - 2 331 1 764 ✅ - 2 433 126 💤 +60 18 ❌ +18 24 🔥 +24

For more details on these failures and errors, see this check.

Results for commit 54b0c30. ± Comparison against base commit 5abb73e.

This pull request removes 777 tests.

org.eclipse.m2e.pde.target.tests.DependencyExclusionTest[1] ‑ testExclusionOfDifferentVersions()[1]
org.eclipse.m2e.pde.target.tests.DependencyExclusionTest[1] ‑ testExclusionOfDirectAndTransitivRequirement()[1]
org.eclipse.m2e.pde.target.tests.DependencyExclusionTest[1] ‑ testExclusionOfDirectRequirement()[1]
org.eclipse.m2e.pde.target.tests.DependencyExclusionTest[1] ‑ testExclusionOfMultipleVersions()[1]
org.eclipse.m2e.pde.target.tests.DependencyExclusionTest[2] ‑ testExclusionOfDifferentVersions()[2]
org.eclipse.m2e.pde.target.tests.DependencyExclusionTest[2] ‑ testExclusionOfDirectAndTransitivRequirement()[2]
org.eclipse.m2e.pde.target.tests.DependencyExclusionTest[2] ‑ testExclusionOfDirectRequirement()[2]
org.eclipse.m2e.pde.target.tests.DependencyExclusionTest[2] ‑ testExclusionOfMultipleVersions()[2]
org.eclipse.m2e.pde.target.tests.MavenFeatureTest[1] ‑ testFeatureArtifact()[1]
org.eclipse.m2e.pde.target.tests.MavenFeatureTest[1] ‑ testLocationContentFeatureGeneration()[1]
…

This pull request skips 36 tests.

org.eclipse.m2e.pde.target.tests.MavenContentTest ‑ testIncludeProvidedInfinite
org.eclipse.m2e.pde.target.tests.MavenContentTest ‑ testJettyWithInDependencies
org.eclipse.m2e.pde.target.tests.OSGiMetadataGenerationTest ‑ testArtifactWithSignature
org.eclipse.m2e.pde.target.tests.OSGiMetadataGenerationTest ‑ testBadDependencyDirect
org.eclipse.m2e.pde.target.tests.OSGiMetadataGenerationTest ‑ testBadDependencyInChain
org.eclipse.m2e.pde.target.tests.OSGiMetadataGenerationTest ‑ testBadSymbolicName
org.eclipse.m2e.pde.target.tests.OSGiMetadataGenerationTest ‑ testConditionalPackage
org.eclipse.m2e.pde.target.tests.OSGiMetadataGenerationTest ‑ testMissingOptionalDependency
org.eclipse.m2e.pde.target.tests.OSGiMetadataGenerationTest ‑ testNonJarArtifactInDependencies
org.eclipse.m2e.pde.target.tests.OSGiMetadataGenerationTest ‑ testNonOSGiArtifact_missingArtifactGenerate_changedCustomInstructions
…

♻️ This comment has been updated with latest results.

laeubi · 2025-08-31T14:15:49Z

/request-license-review

laeubi · 2025-09-16T11:19:19Z

I was now able to make the codebase actually compile with Maven 4.

Copilot

Pull Request Overview

This PR updates Tycho to use Maven 4.0.0-rc-4, making it compatible with the next major version of Maven. The update involves adjusting dependency scopes and adding missing transitive dependencies that were previously provided by Maven 3.

Key changes:

Updated Maven version from 3.9.11 to 4.0.0-rc-4
Removed test scope restrictions from maven-compat dependencies across multiple modules
Added explicit dependencies on maven-compat, javax.inject, and DI framework components (Guice, Sisu)

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pom.xml	Updates Maven version property to 4.0.0-rc-4
tycho-versions-plugin/pom.xml	Removes test scope from maven-compat dependency
tycho-source-plugin/pom.xml	Removes test scope from maven-compat dependency
tycho-packaging-plugin/pom.xml	Removes test scope from maven-compat dependency
tycho-p2-repository-plugin/pom.xml	Removes test scope from maven-compat dependency
tycho-core/pom.xml	Removes test scope from maven-compat dependency
tycho-compiler-plugin/pom.xml	Removes test scope from maven-compat dependency
tycho-eclipse-plugin/pom.xml	Removes test scope and adds javax.inject dependency
tycho-testing-harness/pom.xml	Adds maven-core, maven-compat and DI framework dependencies
tycho-targetplatform/pom.xml	Adds maven-compat and javax.inject dependencies
tycho-surefire/tycho-surefire-plugin/pom.xml	Adds maven-compat dependency
tycho-spi/pom.xml	Adds maven-compat dependency
tycho-sbom/pom.xml	Adds maven-compat dependency
tycho-repository-plugin/pom.xml	Adds maven-compat dependency
tycho-p2-publisher-plugin/pom.xml	Adds maven-compat dependency
tycho-p2-director-plugin/pom.xml	Adds maven-compat dependency
tycho-extras/tycho-pomless/pom.xml	Adds maven-compat dependency
tycho-extras/tycho-pomless/src/main/java/.../TychoPomlessLifecycleParticipant.java	Comments out extension warning code and removes unused imports
tycho-extras/tycho-document-bundle-plugin/pom.xml	Adds maven-compat dependency
tycho-extras/target-platform-validation-plugin/pom.xml	Adds maven-compat dependency
tycho-buildtimestamp-jgit/pom.xml	Adds maven-compat dependency
tycho-baseline-plugin/pom.xml	Adds maven-compat dependency
p2-maven-plugin/pom.xml	Adds maven-compat and javax.inject dependencies with provided scope

laeubi · 2025-12-13T05:21:01Z

Updated to Maven 4-rc5 as it contains some additional compatibility fixes.

laeubi · 2025-12-13T05:56:44Z

/request-license-review

github-actions · 2025-12-13T05:59:30Z

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files):
https://github.com/eclipse-tycho/tycho/actions/runs/20187811144

Add explicit javax.inject dependency for Maven 4 compatibility (#103) * Initial plan * Add javax.inject dependency to fix Maven 4 compilation issues Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com> Fix Maven 4 test failures: Add DynamicImport-Package for p2 repository factories and Eclipse Aether dependencies (#104) * Initial plan * Fix p2 repository factory registration with DynamicImport-Package Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com> * Add aether-impl dependency for Maven 4 test compatibility Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com> * Add Eclipse Aether dependencies for Maven 4 compatibility (partial fix) Maven 4 rc-5's MavenRepositorySystemUtils.newSession() still references old Eclipse Aether classes (org.eclipse.aether.*) but these are not provided transitively. Added aether-api, aether-util, and aether-impl 1.1.0 to provide the base classes. However, ConfigurableVersionSelector is an internal class that was never part of public Aether API and cannot be provided without conflicts. This appears to be a Maven 4 rc-5 bug that should be fixed in the final release. Partial fix for M2E PDE target test failures - core p2 repository functionality works correctly. Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com> Reference maven-resolver-util directly

laeubi · 2026-08-17T10:26:58Z

/request-license-review

github-actions · 2026-08-17T10:28:46Z

/request-license-review

License review requests:

After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status.

Workflow run (with attached summary files):
https://github.com/eclipse-tycho/tycho/actions/runs/32020211538

laeubi added this to the 5.0 milestone Sep 8, 2024

laeubi force-pushed the mvn4 branch 7 times, most recently from d907942 to 7e7357d Compare September 13, 2024 04:29

laeubi force-pushed the mvn4 branch 2 times, most recently from 08df834 to 4d44e7f Compare September 24, 2024 04:45

laeubi modified the milestones: 5.0, 6.0 Mar 19, 2025

laeubi force-pushed the mvn4 branch 2 times, most recently from 6ea68db to 6d7133e Compare August 31, 2025 14:12

This comment was marked as outdated.

Sign in to view

laeubi force-pushed the mvn4 branch from 6d7133e to 4c4a4e8 Compare September 16, 2025 11:18

laeubi force-pushed the mvn4 branch 2 times, most recently from 059428e to d0d8913 Compare September 16, 2025 14:33

laeubi requested a review from Copilot October 19, 2025 09:32

Copilot AI reviewed Oct 19, 2025

View reviewed changes

Comment thread .../tycho-pomless/src/main/java/org/eclipse/tycho/pomless/TychoPomlessLifecycleParticipant.java

laeubi force-pushed the mvn4 branch from d0d8913 to 3014058 Compare October 20, 2025 10:14

laeubi mentioned this pull request Nov 29, 2025

3.9.12 nightly breaks Tycho Maven plugin apache/maven#11493

Closed

laeubi force-pushed the mvn4 branch from 214c94a to 9318b5c Compare December 13, 2025 05:20

laeubi force-pushed the mvn4 branch from 2518a2b to f3c95c8 Compare December 13, 2025 07:37

laeubi and others added 3 commits August 17, 2026 12:09

Ignore some test

d29fa51

Update to rc6

54b0c30

laeubi force-pushed the mvn4 branch from 5eff1e3 to 54b0c30 Compare August 17, 2026 10:23

Navigation Menu

Uh oh!

Update to Maven 4 - #4219

Update to Maven 4#4219
laeubi wants to merge 3 commits into
eclipse-tycho:mainfrom
laeubi:mvn4

laeubi commented Sep 8, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 8, 2024 •

edited

Loading

Uh oh!

laeubi commented Aug 31, 2025

Uh oh!

This comment was marked as outdated.

laeubi commented Sep 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

laeubi commented Dec 13, 2025

Uh oh!

laeubi commented Dec 13, 2025

Uh oh!

github-actions Bot commented Dec 13, 2025

Uh oh!

laeubi commented Aug 17, 2026

Uh oh!

github-actions Bot commented Aug 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

laeubi commented Sep 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

laeubi commented Aug 31, 2025

Uh oh!

This comment was marked as outdated.

laeubi commented Sep 16, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

laeubi commented Dec 13, 2025

Uh oh!

laeubi commented Dec 13, 2025

Uh oh!

github-actions Bot commented Dec 13, 2025

Uh oh!

laeubi commented Aug 17, 2026

Uh oh!

github-actions Bot commented Aug 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

laeubi commented Sep 8, 2024 •

edited

Loading

github-actions Bot commented Sep 8, 2024 •

edited

Loading