Skip to content

(0.62) Reject multiple Signature attributes #24526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pshipton merged 1 commit into from
Aug 12, 2026
+20 −0
Merged

(0.62) Reject multiple Signature attributes #24526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions runtime/bcutil/cfreader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ readAttributes(J9CfrClassFile * classfile, J9CfrAttribute *** pAttributes, U_32
#endif /* defined(J9VM_OPT_VALHALLA_FLATTENABLE_VALUE_TYPES) */
#if JAVA_SPEC_VERSION >= 11
BOOLEAN nestAttributeRead = FALSE;
BOOLEAN signatureAttributeRead = FALSE;
#endif /* JAVA_SPEC_VERSION >= 11 */

if (NULL != syntheticFound) {
Expand Down Expand Up @@ -221,6 +222,17 @@ readAttributes(J9CfrClassFile * classfile, J9CfrAttribute *** pAttributes, U_32
break;

case CFR_ATTRIBUTE_Signature:
#if JAVA_SPEC_VERSION >= 11
/* JVMS 4.7.9: There may be at most one Signature attribute in the attributes table of a
* ClassFile, field_info, method_info, or record_component_info structure.
*/
if (signatureAttributeRead) {
errorCode = J9NLS_CFR_ERR_MULTIPLE_SIGNATURE_ATTRIBUTES__ID;
offset = address;
goto _errorFound;
}
signatureAttributeRead = TRUE;
#endif /* JAVA_SPEC_VERSION >= 11 */
if (!ALLOC_CAST(attrib, J9CfrAttributeSignature, J9CfrAttribute)) {
return -2;
}
Expand Down
8 changes: 8 additions & 0 deletions runtime/nls/cfre/cfrerr.nls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1862,3 +1862,11 @@ J9NLS_CFR_ERR_LOADABLEDESCRIPTORS_INVALID_SIGNATURE.explanation=The LoadableDesc
J9NLS_CFR_ERR_LOADABLEDESCRIPTORS_INVALID_SIGNATURE.system_action=The JVM will throw a java.lang.ClassFormatError.
J9NLS_CFR_ERR_LOADABLEDESCRIPTORS_INVALID_SIGNATURE.user_response=Contact the provider of the classfile for a corrected version.
# END NON-TRANSLATABLE

# Signature is not translatable
J9NLS_CFR_ERR_MULTIPLE_SIGNATURE_ATTRIBUTES=Multiple Signature attributes
# START NON-TRANSLATABLE
J9NLS_CFR_ERR_MULTIPLE_SIGNATURE_ATTRIBUTES.explanation=A ClassFile, field_info, method_info, or record_component_info structure may have at most one Signature attribute.
J9NLS_CFR_ERR_MULTIPLE_SIGNATURE_ATTRIBUTES.system_action=The JVM will throw a classloading related exception such as java.lang.ClassFormatError.
J9NLS_CFR_ERR_MULTIPLE_SIGNATURE_ATTRIBUTES.user_response=Contact the provider of the classfile for a corrected version.
# END NON-TRANSLATABLE