Fix non-Value attribute writes#1792
Merged
kevinherron merged 1 commit intoJul 2, 2026
Merged
Conversation
Non-Value Write requests carry DataValue wrappers, but node setters expect raw attribute values. Unwrap and validate or convert values before setter dispatch so invalid writes return StatusCode results instead of unchecked exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix server-side Write handling for non-Value attributes so requests write the raw attribute value instead of the surrounding
DataValuewrapper. Invalid or incompatible payloads now return operationStatusCoderesults instead of bubbling unchecked setter exceptions.Valueattribute behavior.Key Changes
AttributeId, including special handling forNodeClass, option sets,DataTypeDefinition, and role permission arrays.Bad_TypeMismatch, andUaRuntimeExceptionstatus codes are preserved instead of escaping the Write service path.AttributeWriterTestnow exercises remote Write requests forDisplayName,ArrayDimensions,AccessLevelEx, and mismatched non-Value payloads.References