Preserve Matrix type metadata for empty values#1791
Merged
Conversation
Zero-length structured and enumerated Matrix values are valid, but Matrix previously inferred concrete type metadata from element 0. Preserve explicit DataTypeIds through decode and transform paths so empty matrices do not crash or lose their declared type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow zero-length structured and enumerated Matrix values to retain their declared type metadata across decode, encode, and transform paths.
Key Changes
Matrix metadata: Matrix can now carry an explicit
ExpandedNodeIdfor the concrete element DataType. Empty structured and enumerated arrays no longer attempt to read element 0 during DataTypeId derivation.Decode paths: Structured matrix decoders pass the declared DataTypeId into Matrix construction so empty values keep the schema type known by the caller.
Transform paths: Matrix transformations used by XML encoding and dynamic field codecs can now provide explicit output metadata. This keeps empty transformed matrices valid without changing non-empty inference behavior.
JSON struct codec: Enum and structured matrices created from JSON field definitions preserve the declared DataTypeId before being passed to downstream encoders.
References