Fix session shutdown diagnostics race#1790
Merged
Merged
Conversation
Make server shutdown the synchronization point for session listener callbacks so diagnostics and namespace lifecycles are not torn down while session notifications are still running. Reject new sessions once shutdown begins, make session close idempotent, and shut down managed lifecycle children before unregistering their node managers. This removes sleep-based ordering from tests and examples and covers concurrent and re-entrant shutdown paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make server shutdown the synchronization point for session listener quiescence so diagnostics and namespace teardown no longer race with session callbacks.
Key Changes
OpcUaServer.shutdown()now uses a shared shutdown future so concurrent callers observe the same teardown instead of running namespace and diagnostics shutdown multiple times.SessionManagertracks shutdown state, rejects new sessions withBad_Shutdown, drains listener work, and skips queued callbacks once shutdown starts.server.shutdown()now provides the ordering guarantee.Testing
SessionTestcovers idempotentSession.close(...)behavior and verifies lifecycle listeners are notified once.ServerShutdownSessionDiagnosticsRaceTestcovers blocked session listener shutdown, concurrent shutdown callers, and shutdown requested from inside a session listener callback.mvn -q spotless:applymvn -q -pl opc-ua-sdk/sdk-server -am test -Dtest=SessionTest -Dsurefire.failIfNoSpecifiedTests=falsemvn -q -pl opc-ua-sdk/integration-tests -am test -Dtest=ServerShutdownSessionDiagnosticsRaceTest -Dsurefire.failIfNoSpecifiedTests=falsemvn -q clean compile