Repository navigation
plugarchive: pack the same plugin to the same bytes - #50
Merged
Merged
Conversation
PackDir recorded mtimes, owners and the umask's share of each mode, so two builds of an identical binary were two archives with different sha256s and plugins publish --force re-uploaded every version and made every replica refetch it. Entries now get the epoch, no owner and 0755/0644/0777. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
ZergsLaw
added a commit
that referenced
this pull request
Oct 30, 2026
plugins publish builds and smoke-tests for the platform the service reports in the new PluginsResponse.platform field, or --platform (#51), and packs plugins reproducibly, so an unchanged rebuild is an identical archive that is not uploaded again (#50). Co-authored-by: Edgar Sipki <e.sipki@uzum.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Архив плагина записывал время файлов, владельца и маску прав машины, где шла сборка, поэтому пересборка того же бинарника давала архив с другим sha256, и
plugins publish --forceперезаливал все версии, а реплики их перекачивали. ТеперьPackDirпишет epoch вместо времени, без владельцев и с режимами 0755/0644/0777: две сборкиgrpc/go:v1.6.2дали одинаковый sha, тестTestPackDirIsReproducibleбез правки падает. Архивы, уже лежащие в хранилище, собраны по-старому, так что первый--forceпосле этой версии перезальёт их один раз, дальше неизменённые версии не заливаются.🤖 Generated with Claude Code