Skip to content

fix(windows): accept native separators in relative file name checks #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yakwilik merged 1 commit into from
Nov 1, 2026
Merged

fix(windows): accept native separators in relative file name checks #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/migration/apply.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ func sameSnapshot(before, after snapshot) bool {
}

func checkRelativeName(name string) error {
if !filepath.IsLocal(name) || name == "." || filepath.Clean(name) != name || strings.Contains(name, "\\") {
if !filepath.IsLocal(name) || name == "." || filepath.Clean(name) != name || (filepath.Separator != '\\' && strings.Contains(name, "\\")) {
return fmt.Errorf("unsafe relative file name %q", name)
}
return nil
Expand Down
2 changes: 1 addition & 1 deletion internal/modules/resolved_file_observations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func (tx *resolvedFileObservations) capture(name string, allowed SourceRoots) (r
}

func (tx *resolvedFileObservations) readState(name string, allowed SourceRoots) (_ resolvedFileState, resultErr error) {
if !filepath.IsLocal(name) || name == "." || filepath.Clean(name) != name || strings.Contains(name, "\\") {
if !filepath.IsLocal(name) || name == "." || filepath.Clean(name) != name || (filepath.Separator != '\\' && strings.Contains(name, "\\")) {
return resolvedFileState{}, fmt.Errorf("unsafe relative file name %q", name)
}
view, err := sourceview.NewLocal(tx.root.FS(), tx.canonicalRoot, tx.requestedRoot)
Expand Down
Loading