[ENG-1702] Renovate: track Earthfile tool pins, the lunar-scripts base and GitHub Actions - #303
Open
me-bender[bot] wants to merge 1 commit into
Open
[ENG-1702] Renovate: track Earthfile tool pins, the lunar-scripts base and GitHub Actions#303me-bender[bot] wants to merge 1 commit into
me-bender[bot] wants to merge 1 commit into
Conversation
…e and GitHub Actions
🌙 Earthly Lunar✅ 10 Passing
7 more...
|
There was a problem hiding this comment.
Read the config and every annotation. The regex matches all six pins with the right captures, the datasources are valid (node-version, npm, pypi, github-releases), and extractVersion strips the leading v on exactly the two tools whose install URLs re-add it (hadolint, grype) while staying off ast-grep, which downloads from a bare tag. alpine/python are excluded from the dockerfile manager and lunar-scripts x6 is grouped. renovate-config-validator passes on current renovate (v44); the only local fail was a v39 that predates managerFilePatterns. Does nothing until the app is added to the repo. Clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.github/renovate.json5(same shape as the other earthly repos that use Renovate:config:recommended, Monday schedule,renovatelabel, grouped non-major GitHub Actions) so the pinned tool versions stop rotting until a scanner complains.What it tracks:
ARG <TOOL>_VERSION=pin in an Earthfile that carries a# renovate: datasource=… depName=…comment on the line above (regex custom manager). This PR annotates the pins the ENG-1700 bump PR doesn't touch (checkov, ast-grep, hadolint, grype, node, npm); that PR annotates the ones it bumps.FROMpins in Earthfiles via the dockerfile manager: theearthly/lunar-scripts:$SCRIPTS_VERSIONbase (all six references grouped into one PR) and thegolang:builder image. Test-onlyalpine:/python:images are excluded..github/workflowsand thelunar-policypins in the policies'requirements.txt(built-in managers).<4until the collector is validated on Helm 4.Verification:
renovate-config-validatorpasses;renovate --platform=local --dry-run=lookupon this branch plus the ENG-1700 branch detects 17 regex pins (all lookups resolve, noskipReason), 55 dockerfile deps includingearthly/lunar-scripts×6 and thegolangbuilder, 11 GitHub Actions refs, 56 pip pins.Prerequisite: the Renovate app is installed on the org but lunar-lib is not in its repository list yet, so nothing happens until it is added.