Skip to content

fix: EgovStringUtil.alignLeft 생략 표기 시 원본 전체가 앞에 붙는 문제 수정 #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jei007 merged 1 commit into from
Aug 6, 2026
Merged

fix: EgovStringUtil.alignLeft 생략 표기 시 원본 전체가 앞에 붙는 문제 수정 #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...g.egovframe.rte.fdl.string/src/main/java/org/egovframe/rte/fdl/string/EgovStringUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,9 @@ public static String alignLeft(String str, int length) {
* 문자열의 뒷쪽에 지정한 길이만큼 공백으로 채움
*/
public static String alignLeft(String str, int length, boolean isEllipsis) {
StringBuilder result = new StringBuilder(str);
StringBuilder result = new StringBuilder(length);
if (str.length() <= length) {
result.append(str);
for (int i = 0; i < (length - str.length()); i++) {
result.append(WHITE_SPACE);
}
Expand Down
36 changes: 36 additions & 0 deletions ...ovframe.rte.fdl.string/src/test/java/org/egovframe/rte/fdl/string/EgovStringUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,42 @@ public void testAlignString() {
assertEquals(i, result.length());
}

/**
* 생략 표기(isEllipsis) 옵션이 alignLeft/alignRight/alignCenter에서 동일하게 동작하는지 검사한다.
*/
@Test
public void testAlignStringWithEllipsis() {
String source = "abcdefghij";

// 지정한 길이를 넘으면 뒷부분을 "..."으로 대체하고, 결과 길이는 지정한 길이와 같다
assertEquals("ab...", EgovStringUtil.alignLeft(source, 5, true));
assertEquals("ab...", EgovStringUtil.alignRight(source, 5, true));
assertEquals("ab...", EgovStringUtil.alignCenter(source, 5, true));

// isEllipsis가 false이면 지정한 길이만큼 자른다
assertEquals("abcde", EgovStringUtil.alignLeft(source, 5, false));
assertEquals("abcde", EgovStringUtil.alignRight(source, 5, false));
assertEquals("abcde", EgovStringUtil.alignCenter(source, 5, false));

// 길이가 정확히 같으면 원본을 그대로 반환한다
assertEquals("abcde", EgovStringUtil.alignLeft("abcde", 5, true));
assertEquals("abcde", EgovStringUtil.alignRight("abcde", 5, true));

// 길이가 미달이면 isEllipsis와 무관하게 공백으로 채운다
assertEquals("abc ", EgovStringUtil.alignLeft("abc", 6, true));
assertEquals("abc ", EgovStringUtil.alignLeft("abc", 6, false));
assertEquals(" abc", EgovStringUtil.alignRight("abc", 6, true));

// 빈 문자열은 지정한 길이만큼의 공백이 된다
assertEquals(" ", EgovStringUtil.alignLeft("", 3, true));
assertEquals(" ", EgovStringUtil.alignRight("", 3, true));

// null은 세 메서드 모두 NullPointerException을 발생시킨다
assertThrows(NullPointerException.class, () -> EgovStringUtil.alignLeft(null, 3, true));
assertThrows(NullPointerException.class, () -> EgovStringUtil.alignRight(null, 3, true));
assertThrows(NullPointerException.class, () -> EgovStringUtil.alignCenter(null, 3, true));
}

@Test
public void testEncodePassword() {
// 1. try to encode password and compare
Expand Down