Conversation
adding overrides for main file
breaks zip.js
boostrap 4 breaks other js files otherwise
Collaborator
|
Looks good! I've assigned @matthova to verify that the install is clean, and we need to updated the README to reflect these changes and install information. |
Member
|
Pull request moved from fork to #40 Per the note on the other pull request, we won't be merging until we can migrate away from gh-pages and to a workflow for deploying the built app and stl files to S3. |
Collaborator
|
Since we have a team actively using our tool right now, we need to wait until we are deploying the built app + stl files to S3 before merging. Check for updates on #40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I this pull request:
generator-webappto create a vanilla projectwiredepand custom<script>tags for required files by the project..mvmrcto use NodeJS v5.10To run the project:
nvm useto load the correct version of NodeJSnpm install -g yo@1.8.4 bower@1.7.9 generator-webapp@2.1.0npm install && bower installgulp serveto open the project into browser using BrowserSyncYou can also run
gulp buildto build the project intodistfolder. Then you can rungulp serve:distto run this copy.TODO:
jquery-ui-scssto create a customizable theme and replace the current scss files.favicon.icoandapple-touch-icon.png