fix: restore shader filename to match Rust loader - #42
Closed
dynnamitt wants to merge 1 commit into
Closed
Conversation
Commit c98651e ("screenShot!") accidentally renamed the shader asset from fov_overlay.wgsl to aiming_overlay.wgsl without updating src/h_terrain/fov_overlay.rs, which still loads "shaders/fov_overlay.wgsl" via FovOverlay::fragment_shader and deferred_fragment_shader. The result was a missing-asset error at runtime on every cargo run after that commit. Renaming the file back keeps the Rust struct/file/CLAUDE.md naming (FovOverlay / fov_overlay) consistent with the asset. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit
c98651e("screenShot!") accidentally renamedassets/shaders/fov_overlay.wgsltoaiming_overlay.wgslwithout updatingsrc/h_terrain/fov_overlay.rs:42,46, which still loads"shaders/fov_overlay.wgsl"viaFovOverlay::fragment_shaderanddeferred_fragment_shader.Effect: missing-asset error at runtime on every
cargo runafterc98651e. The deployed v0.0.7 build (tagged before the rename) still works because its bundle containsfov_overlay.wgsl.This PR renames the asset back to keep the Rust struct/file/CLAUDE.md naming (
FovOverlay/fov_overlay) consistent with the asset.Test plan
cargo buildsucceedscargo runstarts up and the FoV overlay renders (visual sanity check)🤖 Generated with Claude Code