Preserve exact EDT suggestion candidates - #170
Open
jackyclever wants to merge 1 commit into
Open
Conversation
jackyclever
marked this pull request as ready for review
August 9, 2026 04:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169.
Summary
{ Name, Model }identity.Root cause
SearchEdtsapplies ordering and a candidate limit beforeEdtSuggesterscores results. A valid exact-name EDT outside that initial fuzzy result window was therefore never considered for the existing1.0exact-match score.Impact
Exact EDT suggestions are no longer silently lost when the fuzzy candidate set is crowded. When the same EDT name exists in multiple models, each qualified candidate remains available for downstream disambiguation.
Validation
dotnet restore d365fo-cli.slnx— passed; NuGet audit reachability and existing package advisory warnings were reported.dotnet build d365fo-cli.slnx --no-restore -c Release -nologo— passed with 0 errors.dotnet test d365fo-cli.slnx --no-build -c Release --logger console;verbosity=minimal— 1,180/1,180 passed outside the restricted sandbox.dotnet run --project src/D365FO.Cli -c Release --no-build -- knowledge audit --verify --output json— passed.dotnet run --project src/D365FO.Cli -c Release --no-build -- eval run --all --output json— 52/52 passed.dotnet run --project src/D365FO.Cli -c Release --no-build -- eval coverage --check --output json— passed.python scripts/emit-skills.py— not run locally because Python is unavailable; the upstream CI skill-drift job remains the verification gate.