Fix state bug in multipage navigation item retrieval - #52
Merged
Conversation
RobjS
force-pushed
the
fix/multipage-in-page-nav-state-bug
branch
from
July 24, 2026 13:03
827079b to
2f5e8ae
Compare
Before: `getItems()` would duplicate the items set if called more than once on the same instance. This could result in navigation rendering incorrectly. Now: it always only returns the single correct set of items. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
RobjS
force-pushed
the
fix/multipage-in-page-nav-state-bug
branch
from
July 24, 2026 13:37
2f5e8ae to
bae2025
Compare
RobjS
marked this pull request as ready for review
July 24, 2026 13:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the multipage navigation functionality by ensuring that repeated calls to
MultipageInPageNavigation::getItems()return consistent results.Before:
getItems()would duplicate the items set if called more than once on the same instance. This could result in navigation rendering incorrectly.Now: it always only returns the single correct set of items.
This PR was co-authored with CoPilot.
How to test
LongReadPlugin\Navigation::getItems()method so it repeatedly gets the in-page items, e.g.