Skip to content

Feature/support preview links for page breaks - #49

Merged
RobjS merged 4 commits into
mainfrom
feature/support-preview-links-for-page-breaks
Jul 16, 2026
Merged

Feature/support preview links for page breaks#49
RobjS merged 4 commits into
mainfrom
feature/support-preview-links-for-page-breaks

Conversation

@RobjS

@RobjS RobjS commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description of changes

This PR adds support for previewing a draft page-break based long read.

Before, the chapter navigation, and pagination links, would not render correctly. Now, they will.

It also does some minor refactoring to make the PageBreakChapterNavigation class more readable.

How to test

  1. Spin up a site that uses this plugin (e.g. UKSS), and checkout this branch
  2. Ensure you have page-break based long reads activated, by setting the DXW_PAGE_BREAK_LONG_READ constant to true.
  3. Create a long-read item that uses page breaks, and save it as draft
  4. Preview the long read, and confirm that chapter navigation and pagination links function correctly

Checklist

  • Changelog updated
  • If new release: major version tag to be bumped after release (see docs)

@william-man william-man left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm, the chapter navigation and page links works while post is in the preview

@RobjS
RobjS merged commit f6041a5 into main Jul 16, 2026
2 checks passed
@RobjS
RobjS deleted the feature/support-preview-links-for-page-breaks branch July 16, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants