Prevent duplicate chapter title and first in-page nav item - #46
Merged
Conversation
For page-break based long reads, we have to assume that the first heading block after a page break is the title of that page/chapter. However, we assemble the in-page nav by getting all the h2 heading blocks within that chapter. This meant that if the first heading after a page break was an h2, that heading would be used as both the title of the chapter in the side nav, and as the first in-page nav item of that chapter. This change checks if the title of the first in-page nav item matches the chapter title, and if so, it removes that in-page nav item. Resolves: #44
matthewpassmore
approved these changes
Jul 16, 2026
matthewpassmore
left a comment
Contributor
There was a problem hiding this comment.
Works as expected 👍
Ignore my flagged issues in the previous PR. I didn't realise that an env var needed setting 🤦
Contributor
Author
I should have made that clearer in the testing instructions, sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For page-break based long reads, we have to assume that the first heading block after a page break is the title of that page/chapter.
However, we assemble the in-page nav by getting all the h2 heading blocks within that chapter.
This meant that if the first heading after a page break was an h2, that heading would be used as both the title of the chapter in the side nav, and as the first in-page nav item of that chapter.
This change checks if the title of the first in-page nav item matches the chapter title, and if so, it removes that in-page nav item.
Resolves: #44
How to test
Checklist